You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/09/06 09:10:15 UTC

[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #70: Amqnet 723

michaelandrepearce commented on a change in pull request #70:
URL: https://github.com/apache/activemq-nms-amqp/pull/70#discussion_r702737820



##########
File path: src/NMS.AMQP/Meta/NmsConnectionInfo.cs
##########
@@ -62,6 +63,9 @@ public NmsConnectionInfo(NmsConnectionId connectionId)
         public string TopicPrefix { get; set; }
         public ushort ChannelMax { get; set; } = DEFAULT_CHANNEL_MAX;
         public int MaxFrameSize { get; set; } = DEFAULT_MAX_FRAME_SIZE;
+
+        public int? MaxMessageSize { get; set; } = DEFAULT_MAX_MESSAGE_SIZE;

Review comment:
       why is this 'int?' why not just int, it has a default.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org