You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/02/03 23:04:35 UTC

[jira] [Commented] (PROTON-814) proton-c: pn_selector_select caches its return code from a previous error

    [ https://issues.apache.org/jira/browse/PROTON-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304103#comment-14304103 ] 

ASF GitHub Bot commented on PROTON-814:
---------------------------------------

GitHub user dnwe opened a pull request:

    https://github.com/apache/qpid-proton/pull/6

    PROTON-814: only return error rc on a failed poll

    In posix pn_selector_select, if a poll() call returns result == -1 and
    sets selector->error from the errno, any subsequent pn_selector_select
    calls on the same selector will return have a return code of the
    previously cached errno even if they succeed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dnwe/qpid-proton fix-proton-814

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6
    
----
commit d3cef91426bbcfc4809f38dbbc87ddd2b3cbdd1e
Author: Dominic Evans <do...@uk.ibm.com>
Date:   2015-02-03T21:56:33Z

    PROTON-814: only return error rc on a failed poll
    
    In posix pn_selector_select, if a poll() call returns result == -1 and
    sets selector->error from the errno, any subsequent pn_selector_select
    calls on the same selector will return have a return code of the
    previously cached errno even if they succeed.

----


> proton-c: pn_selector_select caches its return code from a previous error
> -------------------------------------------------------------------------
>
>                 Key: PROTON-814
>                 URL: https://issues.apache.org/jira/browse/PROTON-814
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.8
>            Reporter: Dominic Evans
>            Assignee: Dominic Evans
>
> In posix pn_selector_select, if a poll() call returns result == -1 and
> sets selector->error from the errno, any subsequent pn_selector_select
> calls on the same selector will return have a return code of the
> previously cached errno even if they succeed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)