You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/10/01 16:00:47 UTC

Review Request 38930: AMS Collector does not start

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38930/
-----------------------------------------------------------

Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.


Bugs: AMBARI-13223
    https://issues.apache.org/jira/browse/AMBARI-13223


Repository: ambari


Description
-------

AMS collector start is failing
export HBASE_MASTER_OPTS=" -Xms1152m -Xmx1152m -Xmn128 -XX:CMSInitiatingOccupancyFraction=70 -XX:+UseC


Diffs
-----

  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 40a3921 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml 7274a12 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/functions.py a5107d6 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 23fe77f 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py a585c6f 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/functions.py e6e7fb9 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 4ec401f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c4450b6 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 97cf4ca 
  ambari-web/app/controllers/wizard/step8_controller.js e149c44 
  ambari-web/app/mixins/common/configs/configs_saver.js a9b6aa2 

Diff: https://reviews.apache.org/r/38930/diff/


Testing
-------

mvn clean test


Thanks,

Dmitro Lisnichenko


Re: Review Request 38930: AMS Collector does not start

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On Oct. 5, 2015, 1:59 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml, line 53
> > <https://reviews.apache.org/r/38930/diff/1/?file=1088503#file1088503line53>
> >
> >     How is this change handled during upgrade? E.g. older deployments with 512m

Makes sence. Fixed


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38930/#review101471
-----------------------------------------------------------


On Oct. 6, 2015, 2:53 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38930/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 2:53 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13223
>     https://issues.apache.org/jira/browse/AMBARI-13223
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMS collector start is failing
> export HBASE_MASTER_OPTS=" -Xms1152m -Xmx1152m -Xmn128 -XX:CMSInitiatingOccupancyFraction=70 -XX:+UseC
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 7caf50e 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 40a3921 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml 7274a12 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/functions.py a5107d6 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 23fe77f 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py a585c6f 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/functions.py e6e7fb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 635be5e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c4450b6 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java b6e0ccb 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py aa9a302 
>   ambari-web/app/controllers/wizard/step8_controller.js be0404c 
>   ambari-web/app/mixins/common/configs/configs_saver.js 6352dec 
> 
> Diff: https://reviews.apache.org/r/38930/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 38930: AMS Collector does not start

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38930/#review101471
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml (line 53)
<https://reviews.apache.org/r/38930/#comment158868>

    How is this change handled during upgrade? E.g. older deployments with 512m


- Sumit Mohanty


On Oct. 1, 2015, 2 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38930/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2015, 2 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13223
>     https://issues.apache.org/jira/browse/AMBARI-13223
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMS collector start is failing
> export HBASE_MASTER_OPTS=" -Xms1152m -Xmx1152m -Xmn128 -XX:CMSInitiatingOccupancyFraction=70 -XX:+UseC
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 40a3921 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml 7274a12 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/functions.py a5107d6 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 23fe77f 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py a585c6f 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/functions.py e6e7fb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 4ec401f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c4450b6 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 97cf4ca 
>   ambari-web/app/controllers/wizard/step8_controller.js e149c44 
>   ambari-web/app/mixins/common/configs/configs_saver.js a9b6aa2 
> 
> Diff: https://reviews.apache.org/r/38930/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 38930: AMS Collector does not start

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38930/#review101464
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Жов. 1, 2015, 2 після полудня, Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38930/
> -----------------------------------------------------------
> 
> (Updated Жов. 1, 2015, 2 після полудня)
> 
> 
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13223
>     https://issues.apache.org/jira/browse/AMBARI-13223
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMS collector start is failing
> export HBASE_MASTER_OPTS=" -Xms1152m -Xmx1152m -Xmn128 -XX:CMSInitiatingOccupancyFraction=70 -XX:+UseC
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 40a3921 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml 7274a12 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/functions.py a5107d6 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 23fe77f 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py a585c6f 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/functions.py e6e7fb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 4ec401f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c4450b6 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 97cf4ca 
>   ambari-web/app/controllers/wizard/step8_controller.js e149c44 
>   ambari-web/app/mixins/common/configs/configs_saver.js a9b6aa2 
> 
> Diff: https://reviews.apache.org/r/38930/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 38930: AMS Collector does not start

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38930/#review101648
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On Окт. 6, 2015, 2:53 п.п., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38930/
> -----------------------------------------------------------
> 
> (Updated Окт. 6, 2015, 2:53 п.п.)
> 
> 
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13223
>     https://issues.apache.org/jira/browse/AMBARI-13223
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMS collector start is failing
> export HBASE_MASTER_OPTS=" -Xms1152m -Xmx1152m -Xmn128 -XX:CMSInitiatingOccupancyFraction=70 -XX:+UseC
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 7caf50e 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 40a3921 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml 7274a12 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/functions.py a5107d6 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 23fe77f 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py a585c6f 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/functions.py e6e7fb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 635be5e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c4450b6 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java b6e0ccb 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py aa9a302 
>   ambari-web/app/controllers/wizard/step8_controller.js be0404c 
>   ambari-web/app/mixins/common/configs/configs_saver.js 6352dec 
> 
> Diff: https://reviews.apache.org/r/38930/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 38930: AMS Collector does not start

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38930/
-----------------------------------------------------------

(Updated Oct. 6, 2015, 2:53 p.m.)


Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.


Changes
-------

Fixed comments


Bugs: AMBARI-13223
    https://issues.apache.org/jira/browse/AMBARI-13223


Repository: ambari


Description
-------

AMS collector start is failing
export HBASE_MASTER_OPTS=" -Xms1152m -Xmx1152m -Xmn128 -XX:CMSInitiatingOccupancyFraction=70 -XX:+UseC


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 7caf50e 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 40a3921 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml 7274a12 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/functions.py a5107d6 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 23fe77f 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py a585c6f 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/functions.py e6e7fb9 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 635be5e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c4450b6 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java b6e0ccb 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py aa9a302 
  ambari-web/app/controllers/wizard/step8_controller.js be0404c 
  ambari-web/app/mixins/common/configs/configs_saver.js 6352dec 

Diff: https://reviews.apache.org/r/38930/diff/


Testing
-------

mvn clean test


Thanks,

Dmitro Lisnichenko


Re: Review Request 38930: AMS Collector does not start

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38930/#review101470
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On Окт. 1, 2015, 2 п.п., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38930/
> -----------------------------------------------------------
> 
> (Updated Окт. 1, 2015, 2 п.п.)
> 
> 
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13223
>     https://issues.apache.org/jira/browse/AMBARI-13223
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMS collector start is failing
> export HBASE_MASTER_OPTS=" -Xms1152m -Xmx1152m -Xmn128 -XX:CMSInitiatingOccupancyFraction=70 -XX:+UseC
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 40a3921 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml 7274a12 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/functions.py a5107d6 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 23fe77f 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py a585c6f 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/functions.py e6e7fb9 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 4ec401f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c4450b6 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 97cf4ca 
>   ambari-web/app/controllers/wizard/step8_controller.js e149c44 
>   ambari-web/app/mixins/common/configs/configs_saver.js a9b6aa2 
> 
> Diff: https://reviews.apache.org/r/38930/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>