You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/28 20:56:25 UTC
[jira] [Commented] (CB-10965) xml helper allows multiple instances
of name to be merge in final dest xml
[ https://issues.apache.org/jira/browse/CB-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214687#comment-15214687 ]
ASF GitHub Bot commented on CB-10965:
-------------------------------------
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/417#issuecomment-202528558
LGTM. Didn't have a time to test it but making `name` a singleton definitely makes sense.
> xml helper allows multiple instances of name to be merge in final dest xml
> --------------------------------------------------------------------------
>
> Key: CB-10965
> URL: https://issues.apache.org/jira/browse/CB-10965
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
> Affects Versions: Master
> Reporter: Carlos Santana
> Priority: Minor
> Labels: common
>
> This some what related to CB-10961
> Create new app
> Add multiple name tags in toplevel config.xml
> <name>app1</name>
> <name>app2</name>
> <platform name="ios">
> <name>app3</name>
> </platform>
> cordova platform add ios
> cordova prepare
> Open platforms/ios/app3/config.xml
> There are multiple instances of name at top level
> <name>app3</name>
> <name>app1</name>
> <name>app2</name>
> The mergeXml function should be updated to avoid this and only allow one final name tag added to top level dest.
> https://github.com/apache/cordova-lib/blob/master/cordova-common/src/util/xml-helpers.js#L198
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org