You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "9aman (via GitHub)" <gi...@apache.org> on 2023/11/22 17:35:58 UTC
[PR] Prevent inverted index on a non dictionary column in table config [pinot]
9aman opened a new pull request, #12043:
URL: https://github.com/apache/pinot/pull/12043
A column should be of Dictionary type for it to have inverted index.
Current Scenario:
A config will be flagged as **invalid** during upsert of table config if the a column is marked as **noDictionaryColumn** and has inverted index enabled. e.g.
[invalid_table_config.json](https://github.com/apache/pinot/files/13442766/invalid_table_config.json)
Issues:
Field Config List can also be used to mark the column's encoding type as RAW (or no dictionary) and enable inverted index on it.
Resoltion:
This PR aims to put similar checks for columns in Field Config List as well e.g.
[invalidConfig_field_config_list.json](https://github.com/apache/pinot/files/13442802/invalidConfig_field_config_list.json)
The response of current and new code on an table config upsert (
[invalidConfig_field_config_list.json](https://github.com/apache/pinot/files/13442845/invalidConfig_field_config_list.json)
) will be following:
Current code: config gets inserted
[prev_resultant_config.json](https://github.com/apache/pinot/files/13442849/prev_resultant_config.json)
New Code: Throws an error: {"code":400,"error":"Invalid TableConfigs. Invalid TableConfigs: transcript2. Cannot create an Inverted Index on column: lastName, specified as a non dictionary column"}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Prevent inverted index on a non dictionary column in table config [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #12043:
URL: https://github.com/apache/pinot/pull/12043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org