You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by filmaj <gi...@git.apache.org> on 2017/05/02 21:43:24 UTC
[GitHub] cordova-android pull request #378: Start of GradleBuilder.js specs
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-android/pull/378
Start of GradleBuilder.js specs
FYI @infil00p
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/filmaj/cordova-android start-gradlebuilder-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/378.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #378
----
commit 75dc2a9f3dc8c47273f020abc70e96b19367673a
Author: filmaj <ma...@gmail.com>
Date: 2017-05-02T21:42:50Z
Start of GradleBuilder.js specs - puts it on the code coverage radar.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #378: Start of GradleBuilder.js specs
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/378
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/378?src=pr&el=h1) Report
> Merging [#378](https://codecov.io/gh/apache/cordova-android/pull/378?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/ee1165ea332391b81cef181e6f8f928c883673f2?src=pr&el=desc) will **decrease** coverage by `2.55%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/cordova-android/pull/378?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 42.07% 39.52% -2.56%
==========================================
Files 14 16 +2
Lines 1338 1551 +213
Branches 245 277 +32
==========================================
+ Hits 563 613 +50
- Misses 775 938 +163
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/378?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/378?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz) | `20% <50%> (ø)` | |
| [...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/378?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==) | `30.13% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/378?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/378?src=pr&el=footer). Last update [ee1165e...75dc2a9](https://codecov.io/gh/apache/cordova-android/pull/378?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #378: Start of GradleBuilder.js specs
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/378
I can't cleanly merge this, it looks like it's already in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #378: Start of GradleBuilder.js specs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/378
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org