[jira] [Commented] (EAGLE-104) Fix the unit test TestHDFSSecuritylogParser

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/EAGLE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073150#comment-15073150 ] 

ASF GitHub Bot commented on EAGLE-104:
--------------------------------------

GitHub user pmujumdar opened a pull request:

    https://github.com/apache/incubator-eagle/pull/43

    https://issues.apache.org/jira/browse/EAGLE-104

    EAGLE-104: Fix the unit test TestHDFSSecuritylogParser
    The problem is that the UGI parsing method is not handling the simple authentication scenario where user name is not a kerberos principal. The patch is a minor refactoring of the method that parses the ugi.
    Added new testcases to validate the changes.  Ran unit tests, no failures in eagle-security.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pmujumdar/incubator-eagle master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #43
    
----
commit 2f79c1f5d1eac076150cfb993e4e0426624f2725
Author: Prasad Mujumdar <pr...@apache.org>
Date:   2015-12-28T20:55:24Z

    EAGLE-104: Fix the unit test TestHDFSSecuritylogParser

----


> Fix the unit test TestHDFSSecuritylogParser  
> ---------------------------------------------
>
>                 Key: EAGLE-104
>                 URL: https://issues.apache.org/jira/browse/EAGLE-104
>             Project: Eagle
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Prasad Mujumdar
>         Attachments: EAGLE-104.1.patch
>
>
> The test fails with following error
> {noformat}
> java.lang.StringIndexOutOfBoundsException">
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1 at
> java.lang.String.substring(String.java:1911) at
> org.apache.eagle.security.util.LogParseUtil.parseUserFromUGI(LogParseUtil.java:39)
> at
> org.apache.eagle.security.securitylog.parse.HDFSSecurityLogParser.parseAttr(HDFSSecurityLogParser.java:78)
> at
> org.apache.eagle.security.securitylog.parse.HDFSSecurityLogParser.parse(HDFSSecurityLogParser.java:52)
> at
> org.apache.eagle.security.TestHDFSSecuritylogParser.test(TestHDFSSecuritylogParser.java:36)
> {noformat}
> Looks like the problem is that the UGI parsing method is not handling the simple authentication scenario where user name is not a kerberos principal. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)