[GitHub] [incubator-doris] imay commented on a change in pull request #3819: [Spark load][Fe 4/6] Add hive external table and update hive table syntax in loadstmt

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #3819:
URL: https://github.com/apache/incubator-doris/pull/3819#discussion_r438178208



##########
File path: docs/zh-CN/sql-reference/sql-statements/Data Definition/CREATE TABLE.md
##########
@@ -131,7 +131,7 @@ under the License.
     
     在 Palo 创建 mysql 表的目的是可以通过 Palo 访问 mysql 数据库。

Review comment:
       Doris

##########
File path: fe/src/main/java/org/apache/doris/analysis/SelectStmt.java
##########
@@ -341,6 +375,8 @@ public void analyze(Analyzer analyzer) throws AnalysisException, UserException {
 
         fromClause_.setNeedToSql(needToSql);
         fromClause_.analyze(analyzer);
+        // TODO: remove when query from hive table is supported
+        checkFromHiveTable(analyzer);

Review comment:
       You can do it in ` fromClause_.analyze(analyzer);`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org