[GitHub] [helix] i3wangyi commented on a change in pull request #431: Refine the WAGED rebalancer related interfaces for integration

[GitBox <gi...@apache.org>]

i3wangyi commented on a change in pull request #431: Refine the WAGED rebalancer related interfaces for integration
URL: https://github.com/apache/helix/pull/431#discussion_r317327250
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
 ##########
 @@ -36,23 +39,47 @@
  * A placeholder before we have the implementation.
  * Weight-Aware Globally-Even Distribute Rebalancer.
  *
- * @see <a href="Design Document">https://github.com/apache/helix/wiki/Design-Proposal---Weight-Aware-Globally-Even-Distribute-Rebalancer</a>
+ * @see <a href="https://github.com/apache/helix/wiki/Design-Proposal---Weight-Aware-Globally-Even-Distribute-Rebalancer">
+ * Design Document
+ * </a>
  */
 public class WagedRebalancer implements GlobalRebalancer<ResourceControllerDataProvider> {
 
 Review comment:
   Why not `GlobalRebalancer<ClusterModelDataProvider>`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org