[GitHub] [couchdb] eiri commented on a change in pull request #3588: Aegis improvements

[GitBox <gi...@apache.org>]

eiri commented on a change in pull request #3588:
URL: https://github.com/apache/couchdb/pull/3588#discussion_r642493092



##########
File path: src/aegis/src/aegis_server.erl
##########
@@ -286,8 +278,10 @@ is_key_fresh(UUID) ->
     Now = fabric2_util:now(sec),
 
     case ets:lookup(?KEY_CHECK, UUID) of
-        [{UUID, ExpiresAt}] when ExpiresAt >= Now -> true;
-        _ -> false
+        [{UUID, ExpiresAt}] when ExpiresAt - ?KEY_EARLY_EXPIRE_SEC > Now ->

Review comment:
       You lost me here - so this makes keys to expire 5 secs earlier, i.e. this is virtually the same as reducing `[aegis] cache_max_age_sec` config parameter on 5 sec less. Expired keys and missing from cache keys are treated the same way by doing sync call, so what the point of this change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org