You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2017/12/01 04:15:48 UTC

[GitHub] keith-turner commented on a change in pull request #328: ACCUMULO-4743 Replaced general custom with tserver prefix for cache config

keith-turner commented on a change in pull request #328: ACCUMULO-4743 Replaced general custom with tserver prefix for cache config
URL: https://github.com/apache/accumulo/pull/328#discussion_r154265158
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
 ##########
 @@ -30,7 +30,7 @@
 
   private final Map<CacheType,BlockCache> caches = new HashMap<>();
 
-  public static final String CACHE_PROPERTY_BASE = Property.GENERAL_ARBITRARY_PROP_PREFIX + "cache.";
+  public static final String CACHE_PROPERTY_BASE = Property.TSERV_PREFIX + "cache.";
 
 Review comment:
   Inorder to avoid system cache properties from conflicting with custom cache config properties, I am thinking it would be better to make this `Property.TSERV_PREFIX + "cache.config."`.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services