You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by robertoandrade <gi...@git.apache.org> on 2016/02/25 05:05:10 UTC
[GitHub] cordova-ios pull request: Replacing SDK/ARCH parameters by new des...
GitHub user robertoandrade opened a pull request:
https://github.com/apache/cordova-ios/pull/197
Replacing SDK/ARCH parameters by new destination parameter
Fixes issues when project has targets using different SDKs, i.e.: watchOS vs iOS.
Addresses https://issues.apache.org/jira/browse/CB-10695
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertoandrade/cordova-ios forkChanges
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/197.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #197
----
commit 1443eef7c034c0172be1b10efa6b791bc3585a92
Author: Roberto Andrade <ro...@cloud.com>
Date: 2016-02-25T04:01:18Z
Replacing SDK/ARCH parameters by new destination parameter. Fixes issues when project has targets using different SDKs, i.e.: watchOS vs iOS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10695 Replacing SDK/ARCH parameters b...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/197#issuecomment-218318589
Successfully manual test by creating a new project and adding the platform by specifying this repo with the changes and:
```
cordova emulate ios
cordova run --device
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10695 Replacing SDK/ARCH parameters b...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/197
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10695 Replacing SDK/ARCH parameters b...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/197#issuecomment-218026643
Even though Travis shows that the tests failed, I tested locally and it passes all tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Replacing SDK/ARCH parameters by new des...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/197#issuecomment-218025924
Can you prefix the title of this issue with "CB-10695"? thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org