[GitHub] [yunikorn-k8shim] craigcondit commented on pull request #616: [YUNIKORN-1806] Add configuration entries for YuniKorn Application Tracking

["craigcondit (via GitHub)" <gi...@apache.org>]

craigcondit commented on PR #616:
URL: https://github.com/apache/yunikorn-k8shim/pull/616#issuecomment-1593946278

   There seem to be several unrelated changes included with this PR. Additionally, it would make more sense for this to go in the core as that's where the functionality for event tracking will be implemented.
   
   Finally, we should attempt to make these configuration options hot-reloadable. This shouldn't be too difficult as most of them simply either turn the feature on or off, or set the max size. Setting the max size will require copying the existing queue to a new one of a different size, but that's all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org