You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nikam14 (via GitHub)" <gi...@apache.org> on 2023/02/25 09:02:54 UTC

[GitHub] [pulsar-site] nikam14 opened a new pull request, #436: Updated the Hashing Scheme url

nikam14 opened a new pull request, #436:
URL: https://github.com/apache/pulsar-site/pull/436

   The URL was not working so updated it
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] nikam14 commented on a diff in pull request #436: Updated the Hashing Scheme url

Posted by "nikam14 (via GitHub)" <gi...@apache.org>.
nikam14 commented on code in PR #436:
URL: https://github.com/apache/pulsar-site/pull/436#discussion_r1117904959


##########
docs/concepts-messaging.md:
##########
@@ -904,7 +904,7 @@ If there is a key attached to message, the messages will be routed to correspond
 
 ### Hashing scheme
 
-{@inject: javadoc:HashingScheme:/client/org/apache/pulsar/client/api/HashingScheme} is an enum that represents sets of standard hashing functions available when choosing the partition to use for a particular message.
+{@inject: javadoc:HashingScheme:/client/2.4.2/org/apache/pulsar/client/api/HashingScheme} is an enum that represents sets of standard hashing functions available when choosing the partition to use for a particular message.

Review Comment:
   Thank You for your guidance , I will improve it .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] nikam14 commented on pull request #436: Updated the Hashing Scheme url

Posted by "nikam14 (via GitHub)" <gi...@apache.org>.
nikam14 commented on PR #436:
URL: https://github.com/apache/pulsar-site/pull/436#issuecomment-1445059460

   I have made the changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #436: Updated the Hashing Scheme url

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #436:
URL: https://github.com/apache/pulsar-site/pull/436#discussion_r1117895541


##########
docs/concepts-messaging.md:
##########
@@ -904,7 +904,7 @@ If there is a key attached to message, the messages will be routed to correspond
 
 ### Hashing scheme
 
-{@inject: javadoc:HashingScheme:/client/org/apache/pulsar/client/api/HashingScheme} is an enum that represents sets of standard hashing functions available when choosing the partition to use for a particular message.
+{@inject: javadoc:HashingScheme:/client/2.4.2/org/apache/pulsar/client/api/HashingScheme} is an enum that represents sets of standard hashing functions available when choosing the partition to use for a particular message.

Review Comment:
   Perhaps you can use:
   
   ```suggestion
   [HashingScheme](/api/client/org/apache/pulsar/client/api/HashingScheme) is an enum that represents sets of standard hashing functions available when choosing the partition to use for a particular message.
   ```
   
   And it will be resolved properly with `script/replace.js`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun merged pull request #436: Updated the Hashing Scheme url

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #436:
URL: https://github.com/apache/pulsar-site/pull/436


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #436: Updated the Hashing Scheme url

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #436:
URL: https://github.com/apache/pulsar-site/pull/436#discussion_r1117925433


##########
docs/concepts-messaging.md:
##########
@@ -904,7 +904,7 @@ If there is a key attached to message, the messages will be routed to correspond
 
 ### Hashing scheme
 
-{@inject: javadoc:HashingScheme:/client/org/apache/pulsar/client/api/HashingScheme} is an enum that represents sets of standard hashing functions available when choosing the partition to use for a particular message.
+[HashingScheme](https://pulsar.apache.org/api/client/2.11.x/org/apache/pulsar/client/api/HashingScheme) is an enum that represents sets of standard hashing functions available when choosing the partition to use for a particular message.

Review Comment:
   ```suggestion
   [HashingScheme](/api/client/org/apache/pulsar/client/api/HashingScheme) is an enum that represents sets of standard hashing functions available when choosing the partition to use for a particular message.
   ```
   
   I think the pattern is as this. I may try to migrate the post replace logic to a preview time avialable TSX component.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-site] github-actions[bot] commented on pull request #436: Updated the Hashing Scheme url

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #436:
URL: https://github.com/apache/pulsar-site/pull/436#issuecomment-1445035637

   @nikam14 Please add the following content to your PR description and select a checkbox:
   ```
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org