You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ga...@apache.org on 2018/09/07 23:38:01 UTC
[mesos] 01/02: Revert "Set 'Connection: close' in the master's
streaming API responses."
This is an automated email from the ASF dual-hosted git repository.
gaston pushed a commit to branch 1.7.x
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 3ea28b29adb041477d36444fe6654f5523adc016
Author: Gastón Kleiman <ga...@apache.org>
AuthorDate: Fri Sep 7 16:21:53 2018 -0700
Revert "Set 'Connection: close' in the master's streaming API responses."
This reverts commit b2f52c9d288080bb13b0b2f06d83fa36128f3dcf.
---
src/master/http.cpp | 29 -----------------------------
1 file changed, 29 deletions(-)
diff --git a/src/master/http.cpp b/src/master/http.cpp
index 91b4c11..e2773ed 100644
--- a/src/master/http.cpp
+++ b/src/master/http.cpp
@@ -834,20 +834,6 @@ Future<Response> Master::Http::subscribe(
Pipe pipe;
OK ok;
- // Since the response is infinite, set the 'Connection: close'
- // header to help indicate to intermediaries (e.g. load
- // balancers, proxies) that the connection SHOULD NOT be
- // re-used. Some intermediaries leave the connection to the
- // server open when a client disconnects in order to re-use
- // the connection as an optimization. In these cases, the
- // subscribers do not get removed when the end client
- // disconnects!
- //
- // TODO(bmahler): Libprocess currently doesn't close the
- // the connection based on a handler setting this header,
- // but it doesn't matter here since the response is infinite.
- ok.headers["Connection"] = "close";
-
ok.headers["Content-Type"] = stringify(contentType);
ok.type = Response::PIPE;
ok.reader = pipe.reader();
@@ -1029,21 +1015,6 @@ Future<Response> Master::Http::scheduler(
Pipe pipe;
OK ok;
-
- // Since the response is infinite, set the 'Connection: close'
- // header to help indicate to intermediaries (e.g. load
- // balancers, proxies) that the connection SHOULD NOT be
- // re-used. Some intermediaries leave the connection to the
- // server open when a client disconnects in order to re-use
- // the connection as an optimization. In these cases, the
- // scheduler would not get removed when it disconnects from
- // the intermediary!
- //
- // TODO(bmahler): Libprocess currently doesn't close the
- // the connection based on a handler setting this header,
- // but it doesn't matter here since the response is infinite.
- ok.headers["Connection"] = "close";
-
ok.headers["Content-Type"] = stringify(acceptType);
ok.type = Response::PIPE;