[GitHub] [nifi] YolandaMDavis commented on a change in pull request #3943: NIFI-6947: Add PutRecord processor using RecordSinkService

[GitBox <gi...@apache.org>]

YolandaMDavis commented on a change in pull request #3943: NIFI-6947: Add PutRecord processor using RecordSinkService
URL: https://github.com/apache/nifi/pull/3943#discussion_r360920411
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-services/nifi-record-sink-api/src/main/java/org/apache/nifi/record/sink/RetryableIOException.java
 ##########
 @@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.record.sink;
+
+import java.io.IOException;
+
+/**
+ * This is a marker class for IOExceptions that may succeed if the operation is performed again, it is a hint to retry the operation
+ */
+public class RetryableIOException extends IOException {
 
 Review comment:
   @mattyb149 I see this exception is created and handled but not necessarily used in this PR. Assuming this would be available for future RecordSinkService implementations?  If so recommend just adding a test if possible for that exception branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services