You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/12/06 17:33:10 UTC
[GitHub] [orc] Fokko opened a new pull request, #1334: ORC-1333: Exclude the proto files from the nohive jar
Fokko opened a new pull request, #1334:
URL: https://github.com/apache/orc/pull/1334
### Why are the changes needed?
We're seeing some conflicts in the proto files when updating Iceberg in Trino: https://github.com/trinodb/trino/pull/15079#discussion_r1025121839
I think we should exclude the proto files from the `nohive` jar.
Before the change:
```
➜ java git:(main) ✗ rm -rf core/target/
➜ java git:(main) ✗ mvn package -DskipTests
➜ java git:(main) ✗ cd core/target
➜ target git:(main) ✗ unzip orc-core-1.9.0-SNAPSHOT-nohive.jar
➜ target git:(main) find . | grep -i "google/protobuf/"
./google/protobuf/timestamp.proto
./google/protobuf/field_mask.proto
./google/protobuf/api.proto
./google/protobuf/duration.proto
./google/protobuf/struct.proto
./google/protobuf/wrappers.proto
./google/protobuf/source_context.proto
./google/protobuf/any.proto
./google/protobuf/type.proto
./google/protobuf/empty.proto
./google/protobuf/compiler
./google/protobuf/compiler/plugin.proto
./google/protobuf/descriptor.proto
```
After the change:
```
➜ java git:(main) ✗ rm -rf core/target/
➜ java git:(main) ✗ mvn package -DskipTests
➜ java git:(main) ✗ cd core/target
➜ target git:(main) ✗ unzip orc-core-1.9.0-SNAPSHOT-nohive.jar
➜ target git:(main) ✗ find . | grep -i "google/protobuf/"
∅
```
Interestingly enough, the normal jar doesn't contain these proto files:
```
➜ java git:(main) ✗ rm -rf core/target/
➜ java git:(main) ✗ mvn package -DskipTests
➜ java git:(main) ✗ cd core/target
➜ target git:(main) unzip orc-core-1.9.0-SNAPSHOT.jar| grep -i proto
➜ target git:(main) find . | grep -i "google/protobuf/"
∅
```
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
Exclude the proto files
### How was this patch tested?
Inspecting the produced jar
Closes https://github.com/apache/orc/issues/1333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1334: ORC-1333: Exclude the proto files from the nohive jar
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1334:
URL: https://github.com/apache/orc/pull/1334#issuecomment-1339781261
BTW, @Fokko . We recently released Apache ORC 1.8.1. So, 1.8.2 is scheduled on March 03, 2023 (https://github.com/apache/orc/milestone/15). Is it okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1334: ORC-1327: Exclude the proto files from the nohive jar
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1334:
URL: https://github.com/apache/orc/pull/1334#issuecomment-1339798845
Oh, @Fokko . I was handling it by myself as I mentioned https://github.com/apache/orc/pull/1334#issuecomment-1339791782
- https://github.com/apache/orc/commit/5ea8c06a88657b09b3481378c2cd5b7a64954926 (master)
- https://github.com/apache/orc/commit/7bfdaaf717dd1769fb6d6d1d4085a32fea65ea32 (branch-1.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1334: ORC-1333: Exclude the proto files from the nohive jar
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1334:
URL: https://github.com/apache/orc/pull/1334#issuecomment-1339784830
Oh, @Fokko , what is ORC-1333? It's not Apache ORC JIRA ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] Fokko commented on pull request #1334: ORC-1333: Exclude the proto files from the nohive jar
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #1334:
URL: https://github.com/apache/orc/pull/1334#issuecomment-1339784624
@dongjoon-hyun Thanks. It depends, if Trino is fine with excluding the proto files then March next year would be perfectly fine. Otherwise, it would be great to fast-track it if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1334: ORC-1333: Exclude the proto files from the nohive jar
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #1334: ORC-1333: Exclude the proto files from the nohive jar
URL: https://github.com/apache/orc/pull/1334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1334: ORC-1333: Exclude the proto files from the nohive jar
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1334:
URL: https://github.com/apache/orc/pull/1334#issuecomment-1339787912
It's reverted from main/branch-1.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1334: ORC-1333: Exclude the proto files from the nohive jar
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1334:
URL: https://github.com/apache/orc/pull/1334#issuecomment-1339791782
I'm working on ORC JIRA and recommitting, @Fokko . There is nothing to do from your side~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] Fokko commented on pull request #1334: ORC-1333: Exclude the proto files from the nohive jar
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #1334:
URL: https://github.com/apache/orc/pull/1334#issuecomment-1339796847
@dongjoon-hyun Ah, race condition. I created a new PR: https://github.com/apache/orc/pull/1335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] Fokko commented on pull request #1334: ORC-1333: Exclude the proto files from the nohive jar
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #1334:
URL: https://github.com/apache/orc/pull/1334#issuecomment-1339772505
Thanks @dongjoon-hyun that would be great! 🙏🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1334: ORC-1333: Exclude the proto files from the nohive jar
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1334:
URL: https://github.com/apache/orc/pull/1334#issuecomment-1339786827
My bad. Let me revert this. Unfortunately, it's not Apache ORC way, @Fokko .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] Fokko commented on pull request #1334: ORC-1333: Exclude the proto files from the nohive jar
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #1334:
URL: https://github.com/apache/orc/pull/1334#issuecomment-1339786188
@dongjoon-hyun it is the ID of the GitHub Issue: https://github.com/apache/orc/issues/1333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org