[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4538: [KYUUBI #4537][Improvement][UI] Enabled Vite Server Proxy for developer work in local with frontend and backend server

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #4538:
URL: https://github.com/apache/kyuubi/pull/4538#discussion_r1138499302


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -58,10 +58,15 @@ class KyuubiRestFrontendService(override val serverable: Serverable)
 
   lazy val host: String = conf.get(FRONTEND_REST_BIND_HOST)
     .getOrElse {
-      if (conf.get(KyuubiConf.FRONTEND_CONNECTION_URL_USE_HOSTNAME)) {
-        Utils.findLocalInetAddress.getCanonicalHostName
+      if (Utils.isWindows || Utils.isMac) {
+        warn(s"Kyuubi Server run in Windows or Mac environment, binding $getName to 0.0.0.0")
+        "0.0.0.0"
       } else {
-        Utils.findLocalInetAddress.getHostAddress
+        if (conf.get(KyuubiConf.FRONTEND_CONNECTION_URL_USE_HOSTNAME)) {
+          Utils.findLocalInetAddress.getCanonicalHostName
+        } else {
+          Utils.findLocalInetAddress.getHostAddress
+        }

Review Comment:
   ```
   if {
   
   } else if {
   
   } else {
   
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org