You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Crim <gi...@git.apache.org> on 2017/05/23 12:31:48 UTC
[GitHub] storm pull request #2136: [STORM-2206] - replacing visualization with viz.js
GitHub user Crim opened a pull request:
https://github.com/apache/storm/pull/2136
[STORM-2206] - replacing visualization with viz.js
Still a work in progress.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Crim/storm sp/STORM-2206
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2136
----
commit c5a7c3f6eef76886695949ec1026cb158fc1958b
Author: stephen powis <sp...@salesforce.com>
Date: 2017-05-21T17:00:45Z
[STORM-2206] - initial checkin of visualization using vis.js
[STORM-2206] - initial checkin of visualization using vis.js
[STORM-2206] - initial checkin of visualization using vis.js
[STORM-2206] - checkin missing assets
[STORM-2206] - replace inline html generation with mustache templates
commit 53933ac6d1c4b78134a5d3e9afc9daf9faaa5588
Author: stephen powis <sp...@salesforce.com>
Date: 2017-05-23T08:53:29Z
[STORM-2206] - update RAT plugin, update LICENSE
commit 73ec39b21a678cd5db343a551dee2522da37625f
Author: stephen powis <sp...@salesforce.com>
Date: 2017-05-23T11:20:38Z
[STORM-2206] - use sanitized stream names
commit 9991c43170726d6b6d80fa216a13bba552bf9aec
Author: stephen powis <sp...@salesforce.com>
Date: 2017-05-23T11:48:20Z
[STORM-2206] - sort list, enable system bolts
commit 30acc71f3f58b16942a552a79d0a30ffad07033b
Author: stephen powis <sp...@salesforce.com>
Date: 2017-05-23T12:07:35Z
[STORM-2206] - fix LICENSE, start namespacing visualization.js
commit 5f18f1d808e4cffb9ca75aad1b71e8c90b8ab335
Author: stephen powis <sp...@salesforce.com>
Date: 2017-05-23T12:15:18Z
[STORM-2206] - adjust license, small tweaks
commit d4008b3250c44a8fb8cdca4d26e64cdf22275047
Author: stephen powis <sp...@salesforce.com>
Date: 2017-05-23T12:30:15Z
[STORM-2206] - tweak bolt/spout slideout
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2136: [STORM-2206] - replacing visualization with viz.js
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2136: [STORM-2206] - replacing visualization with viz.js
Posted by Crim <gi...@git.apache.org>.
Github user Crim commented on the issue:
https://github.com/apache/storm/pull/2136
@revans2 I've updated it to denote components starting with __ as "system" rather than spout. It would seem like the visualization end point is mis-reporting them as spouts when they should be something else.
Regarding the acker instances showing 0, that's also what the visualization api end point is returning. Unfortunately my clojure isn't so great and I wasn't able to correctly track down how these things get populated within the end point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2136: [STORM-2206] - replacing visualization with viz.js
Posted by Crim <gi...@git.apache.org>.
Github user Crim commented on the issue:
https://github.com/apache/storm/pull/2136
@revans2 created STORM-2533 and STORM-2534 capturing the two issues w/ the visualization api end point that we uncovered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2136: [STORM-2206] - replacing visualization with viz.js
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2136
It is looking good. A few notes.
Ackers (__acker) are not spouts. They are bolts (but it might be nice to distinguish between system bolts and other bolts)
Ackers are not showing any instances even when there are some.
The System Bolt (__system) is a bolt but not really, and probably does not need to show up here at all. It is created as a way to collect metrics and may go away in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---