You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2017/07/18 08:52:44 UTC
kafka git commit: MINOR: Remove flaky assertion in
verifyCloseOldestConnectionWithStagedReceives
Repository: kafka
Updated Branches:
refs/heads/trunk d663005fd -> 454f0f1ca
MINOR: Remove flaky assertion in verifyCloseOldestConnectionWithStagedReceives
This seems to fail a lot in Jenkins although it always passes locally
for me. Removing the assertion to restore Jenkins stability while
we investigate in more detail.
Author: Ismael Juma <is...@juma.me.uk>
Reviewers: Damian Guy <da...@gmail.com>, Rajini Sivaram <ra...@googlemail.com>
Closes #3543 from ijuma/remove-selector-test-assertion
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/454f0f1c
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/454f0f1c
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/454f0f1c
Branch: refs/heads/trunk
Commit: 454f0f1ca1eccbeba6c459ce62c8e1caa4cf9a70
Parents: d663005
Author: Ismael Juma <is...@juma.me.uk>
Authored: Tue Jul 18 09:52:24 2017 +0100
Committer: Ismael Juma <is...@juma.me.uk>
Committed: Tue Jul 18 09:52:24 2017 +0100
----------------------------------------------------------------------
.../src/test/java/org/apache/kafka/common/network/SelectorTest.java | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/454f0f1c/clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
----------------------------------------------------------------------
diff --git a/clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java b/clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
index 76ebb21..cc061da 100644
--- a/clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
+++ b/clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
@@ -315,7 +315,6 @@ public class SelectorTest {
assertFalse("Disconnect notified too early", selector.disconnected().containsKey(id));
}
}
- assertEquals(maxStagedReceives, completedReceives);
assertEquals(stagedReceives, completedReceives);
assertNull("Channel not removed", selector.channel(id));
assertNull("Channel not removed", selector.closingChannel(id));