[jira] [Commented] (IGNITE-19533) Rename UNKNOWN_ERR error code to INTERNAL_ERR

["Alexander Lapin (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-19533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725806#comment-17725806 ] 

Alexander Lapin commented on IGNITE-19533:
------------------------------------------

[~slava.koptilin] LGTM!

> Rename UNKNOWN_ERR error code to INTERNAL_ERR
> ---------------------------------------------
>
>                 Key: IGNITE-19533
>                 URL: https://issues.apache.org/jira/browse/IGNITE-19533
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Vyacheslav Koptilin
>            Assignee: Vyacheslav Koptilin
>            Priority: Major
>              Labels: iep-84, ignite-3
>             Fix For: 3.0.0-beta2
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The UNKNOWN_ERR error code should be renamed to INTERNAL_ERR. The @Deprecated should be removed as well.
> The INTRNAL_ERR error code should be considered as the product's internal error caused by faulty logic or coding in the product. In general, this error code represents a non-recoverable error that should be provided to code maintainers.
> It seems to me the UNEXPECTED_ERR and Sql.INTERNAL_ERR  error codes just duplicate the `Common.INTERNAL_ERR` one, so, both of them should be removed.
> [1] https://docs.oracle.com/en/database/oracle/oracle-database/19/errmg/using-messages.html#GUID-3D523C69-502E-4E8B-8E56-BEA97EBE50ED
> {noformat}
> ORA-00600: internal error code, arguments: [string], [string], [string], [string], [string], [string], [string], [string], [string], [string], [string], [string]
> Cause: This is the generic internal error number for Oracle program exceptions. It indicates that a process has encountered a low-level, unexpected condition. The first argument is the internal message number. This argument and the database version number are critical in identifying the root cause and the potential impact to your system.
> Action: Visit My Oracle Support to access the ORA-00600 Lookup tool (reference Note 600.1) for more information regarding the specific ORA-00600 error encountered. An Incident has been created for this error in the Automatic Diagnostic Repository (ADR). When logging a service request, use the Incident Packaging Service (IPS) from the Support Workbench or the ADR Command Interpreter (ADRCI) to automatically package the relevant trace information (reference My Oracle Support Note 411.1). The following information should also be gathered to help determine the root cause: - changes leading up to the error - events or unusual circumstances leading up to the error - operations attempted prior to the error - conditions of the operating system and databases at the time of the error Note: The cause of this message may manifest itself as different errors at different times. Be aware of the history of errors that occurred before this internal error.
> {noformat}
> [2] https://www.postgresql.org/docs/current/errcodes-appendix.html
> {noformat}
> Class XX — Internal Error
> XX000	internal_error
> XX001	data_corrupted
> XX002	index_corrupted
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)