You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/24 01:19:00 UTC
[GitHub] mistercrunch commented on a change in pull request #5067: Allow
multiple time shifts
mistercrunch commented on a change in pull request #5067: Allow multiple time shifts
URL: https://github.com/apache/incubator-superset/pull/5067#discussion_r190442395
##########
File path: superset/assets/src/explore/controls.jsx
##########
@@ -1575,11 +1575,20 @@ export const controls = {
},
time_compare: {
- type: 'TextControl',
+ type: 'SelectControl',
+ multi: true,
Review comment:
I think that there's an open PR that makes this backward compatible. Here: https://github.com/apache/incubator-superset/pull/5057 , otherwise I think it would fail for previously saved charts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org