You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/11 11:00:06 UTC

[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #35: use org.apache.pekko as org id

pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko/pull/35#discussion_r1020114527


##########
akka-docs/src/main/paradox/actors.md:
##########
@@ -7,13 +7,13 @@
 To use Classic Actors, add the following dependency in your project:
 
 @@dependency[sbt,Maven,Gradle] {
-  bomGroup=com.typesafe.akka bomArtifact=akka-bom_$scala.binary.version$ bomVersionSymbols=AkkaVersion
+  bomGroup=org.apache.pekko bomArtifact=akka-bom_$scala.binary.version$ bomVersionSymbols=AkkaVersion
   symbol1=AkkaVersion
   value1="$akka.version$"
-  group="com.typesafe.akka"
+  group="org.apache.pekko"
   artifact="akka-actor_$scala.binary.version$"
   version=AkkaVersion
-  group2="com.typesafe.akka"
+  group2="org.apache.pekko"

Review Comment:
   I'm between a rock and a hard place. If I do many PRs with smaller changes, people might review them. If I do all the changes in one PR, most people will refuse to review it.
   
   https://github.com/apache/incubator-pekko/pull/20 renames some of the modules. Another PR or 2 like #20 and all the modules will be renamed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org