You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/12/13 15:37:33 UTC
Re: Review Request 63955: Validate blueprint does not allow lzo enable
without setup with license agreement.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63955/#review193685
-----------------------------------------------------------
Has this been pushed? If so, please close the review.
- Nate Cole
On Nov. 20, 2017, 12:06 p.m., Myroslav Papirkovskyy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63955/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2017, 12:06 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sid Wagle.
>
>
> Bugs: AMBARI-22480
> https://issues.apache.org/jira/browse/AMBARI-22480
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Blueprint validation should fail if LZO is enabled and GPL license is not accepted on server setup.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 1c127c080cd33314e47bcfff63e0c1e6d58937bc
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java c9dc7281a092ff9f22551c9f8fc64ebca15fda36
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java 1d917e0940b1ba5988a740005017c9d228e46f96
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java 206d161fc694f67ae982ef668c5057b4bacec59b
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 1aaa5ce66d1a5385018e4f29c92441e157c2be02
> ambari-server/src/main/java/org/apache/ambari/server/topology/GPLLicenseNotAcceptedException.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java fdbc0807788377f689e19200be9d6cdc2c992690
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java ea6bee314192f0665d4df652cf0c401e0218026f
>
>
> Diff: https://reviews.apache.org/r/63955/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Myroslav Papirkovskyy
>
>
Re: Review Request 63955: Validate blueprint does not allow lzo enable
without setup with license agreement.
Posted by Nate Cole <nc...@hortonworks.com>.
> On Dec. 13, 2017, 10:37 a.m., Nate Cole wrote:
> > Has this been pushed? If so, please close the review.
Ping
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63955/#review193685
-----------------------------------------------------------
On Nov. 20, 2017, 12:06 p.m., Myroslav Papirkovskyy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63955/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2017, 12:06 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sid Wagle.
>
>
> Bugs: AMBARI-22480
> https://issues.apache.org/jira/browse/AMBARI-22480
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Blueprint validation should fail if LZO is enabled and GPL license is not accepted on server setup.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 1c127c080cd33314e47bcfff63e0c1e6d58937bc
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java c9dc7281a092ff9f22551c9f8fc64ebca15fda36
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java 1d917e0940b1ba5988a740005017c9d228e46f96
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java 206d161fc694f67ae982ef668c5057b4bacec59b
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 1aaa5ce66d1a5385018e4f29c92441e157c2be02
> ambari-server/src/main/java/org/apache/ambari/server/topology/GPLLicenseNotAcceptedException.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java fdbc0807788377f689e19200be9d6cdc2c992690
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java ea6bee314192f0665d4df652cf0c401e0218026f
>
>
> Diff: https://reviews.apache.org/r/63955/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Myroslav Papirkovskyy
>
>