You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/13 12:41:44 UTC
[GitHub] [airflow] turbaszek opened a new pull request #10318: [AIRFLOW-6706] Lazy load operator extra links (#7327)
turbaszek opened a new pull request #10318:
URL: https://github.com/apache/airflow/pull/10318
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #10171
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10318: [AIRFLOW-6706] Lazy load operator extra links (#7327)
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10318:
URL: https://github.com/apache/airflow/pull/10318#discussion_r469925942
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -49,6 +50,17 @@
log = logging.getLogger(__name__)
+BUILTIN_OPERATOR_EXTRA_LINKS = [
+ "irflow.contrib.operators.bigquery_operator.bigquery.BigQueryConsoleLink",
Review comment:
missing "a" s here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10318: [AIRFLOW-6706] Lazy load operator extra links (#7327)
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10318:
URL: https://github.com/apache/airflow/pull/10318#issuecomment-673500429
SHll we un-draft and rerun it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #10318: [AIRFLOW-6706] Lazy load operator extra links (#7327)
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #10318:
URL: https://github.com/apache/airflow/pull/10318#issuecomment-673499705
I tested it with:
```python
# bq.py
from airflow.models import BaseOperatorLink
class BigQueryConsoleLink(BaseOperatorLink):
name = 'BigQuery Console'
def get_link(self, operator, dttm):
return "teees"
```
and DAG:
```python
class CustomOp(DummyOperator):
@property
def operator_extra_links(self):
return (BigQueryConsoleLink(),)
with DAG("example_link",
schedule_interval=None, # Override to match your needs
start_date=days_ago(1),
) as dag:
task = CustomOp(task_id="task_withlink")
```
I added `bq.BigQueryConsoleLink` to `BUILTIN_OPERATOR_EXTRA_LINKS` and I see no atomic cloud <3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10318: [AIRFLOW-6706] Lazy load operator extra links (#7327)
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10318:
URL: https://github.com/apache/airflow/pull/10318#issuecomment-673507209
airflow/plugins_manager.py:118:1: E303 too many blank lines (3)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #10318: [AIRFLOW-6706] Lazy load operator extra links (#7327)
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10318:
URL: https://github.com/apache/airflow/pull/10318
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org