You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "jomarko (via GitHub)" <gi...@apache.org> on 2024/05/22 12:33:12 UTC

[PR] NO-ISSUE: Prevent from 'Include model' click in case of empty model [incubator-kie-tools]

jomarko opened a new pull request, #2353:
URL: https://github.com/apache/incubator-kie-tools/pull/2353

   ### Before
   Imagine there is folder with two DMN model and both are empty - there is no node or custom data type defined in them. That is a similar to situation to early phase of any project.
   
   Now please follow these steps.
   - lets say models have names **a.dmn** and **b.dmn**
   - open the model **a**
   - click the included models tab
   - try to import the model **b**
   - you will be in situation like shown in the attached screenshot
   - then press **Include model** button - **Here is the issue, nothing happens**
   
   and there will be an error in js console
   
   ### Now
   User is prevented from clicking 'Include model' in case the model can not be included.
   ![Screenshot 2024-05-22 142715](https://github.com/apache/incubator-kie-tools/assets/8044780/5aad3049-a800-450d-99ea-bf470a408dcf)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] NO-ISSUE: DMN Editor: Prevent from 'Include model' click in case of empty model [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #2353:
URL: https://github.com/apache/incubator-kie-tools/pull/2353#discussion_r1610382738


##########
packages/dmn-editor/src/includedModels/IncludedModels.css:
##########
@@ -0,0 +1,3 @@
+.selected-model-to-include-error {

Review Comment:
   Please use the `kie-dmn-editor--` prefix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] NO-ISSUE: DMN Editor: Prevent from 'Include model' click in case of empty model [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko commented on code in PR #2353:
URL: https://github.com/apache/incubator-kie-tools/pull/2353#discussion_r1610928786


##########
packages/dmn-editor/src/includedModels/IncludedModels.css:
##########
@@ -0,0 +1,3 @@
+.selected-model-to-include-error {

Review Comment:
   Sure, good point, added in new commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] NO-ISSUE: DMN Editor: Prevent from 'Include model' click in case of empty model [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2353:
URL: https://github.com/apache/incubator-kie-tools/pull/2353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org