[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #54: SLING-9469| add configuration to replace manifest properties values

[GitBox <gi...@apache.org>]

cziegeler commented on a change in pull request #54:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/54#discussion_r429792850



##########
File path: src/main/java/org/apache/sling/feature/maven/mojos/ApisJarMojo.java
##########
@@ -1582,6 +1589,14 @@ private File createArchive(final ApisJarContext ctx,
             archiveConfiguration.addManifestEntry("Specification-Vendor", project.getOrganization().getName());
         }
 
+        // replace manifest entries with the one provided in properties configuration
+        Map<String,String> archiveConfigMap =  archiveConfiguration.getManifestEntries();
+        for (final String name: manifestProperties.stringPropertyNames()){
+            if(archiveConfigMap.containsKey(name))

Review comment:
       Why is this if needed? Without it, you could add properties to the manifest - and not just replace




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org