[GitHub] [incubator-iceberg] manishmalhotrawork edited a comment on issue #499: Add persistent IDs to partition fields (WIP)

[GitBox <gi...@apache.org>]

manishmalhotrawork edited a comment on issue #499: Add persistent IDs to partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#issuecomment-540821308
 
 
   @rdblue thanks.
   
   >It looks like this is trying to assign the same IDs for a spec each time it is created, but I think the approach should be to assign IDs to each field in a spec.
   
   `PartitionSpecParser.getLastPartitionField(JsonNode manifestSchemaJson)` is parsing the old PartitionSpec manifestSchema to find the max id from the field list. and this Id will be used as the init Id if new PartitionSpec is added. My understanding was to use the persistent partition field_id, and then use +1 of it for next partitionSpec. So that 2 partitionSpec will not have same partition_field Id.
   
   > The JSON serialization should be updated to parse an ID for each field. That's a good place to start, just adding the ability to track an ID for each partition field
   
   I believe you meant when Avro file is created using `AvroFileAppender`?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org