You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/09 07:24:35 UTC
[GitHub] [dubbo-getty] codecov-commenter edited a comment on pull request #56: Ftr: delete session.handleLoop
codecov-commenter edited a comment on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-869159450
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#56](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4920f0c) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/3eb8b38bb0572be5e2ac243c7cd9c9874e66b2df?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3eb8b38) will **decrease** coverage by `1.82%`.
> The diff coverage is `65.06%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-getty/pull/56/graphs/tree.svg?width=650&height=150&src=pr&token=WDmUsbxiLS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 68.06% 66.24% -1.83%
==========================================
Files 8 8
Lines 1284 1256 -28
==========================================
- Hits 874 832 -42
- Misses 318 331 +13
- Partials 92 93 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [const.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3QuZ28=) | `75.00% <ø> (ø)` | |
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b3B0aW9ucy5nbw==) | `81.25% <ø> (ø)` | |
| [tls.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGxzLmdv) | `0.00% <ø> (ø)` | |
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50Lmdv) | `67.41% <14.28%> (ø)` | |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Vzc2lvbi5nbw==) | `66.02% <52.50%> (-5.38%)` | :arrow_down: |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyLmdv) | `65.71% <66.66%> (ø)` | |
| [connection.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29ubmVjdGlvbi5nbw==) | `78.96% <90.90%> (+0.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [03651ca...4920f0c](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org