[GitHub] [arrow-adbc] WillAyd commented on a diff in pull request #758: feat(c/driver/postgresql): add timestamp types support

["WillAyd (via GitHub)" <gi...@apache.org>]

WillAyd commented on code in PR #758:
URL: https://github.com/apache/arrow-adbc/pull/758#discussion_r1224823181


##########
c/driver/postgresql/postgres_type.h:
##########
@@ -223,6 +223,14 @@ class PostgresType {
         NANOARROW_RETURN_NOT_OK(ArrowSchemaSetType(schema, NANOARROW_TYPE_BINARY));
         break;
 
+      case PostgresTypeId::kTimestamp:
+        // TODO: it's possible to set a precision in the type, but how do we get that

Review Comment:
   I think this is always correct. You can set a precision with the timestamp, but it doesn't change the underlying storage type or resolution
   
   https://www.postgresql.org/docs/current/datatype-datetime.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org