[DISCUSS] Stale Pull Requests

["P. Taylor Goetz" <pt...@gmail.com>]

I did a quick survey of open pull requests on github, and found a bunch that might be candidates for closing.

Below is a list of PRs, oldest to newest,  that are either old, or getting old, and that we should think about closing or moving forward with. Some of them have supportive comments from committers. The text in parens are my quick-and-dirty (i.i. random!) notes.

All: Please chime in if you have an opinion on any of the below.

Contributors: If you are an author of a pull request that you don’t intend to continue supporting, please close the pull request, or find a committer who is willing to support it.

Committers: Please review. Especially if you vetoed and there have been commits since you did so. As far as committing, you don’t need to waIt for an upmerge if you think it’s an important change. Deconflict it yourself, and if you have any doubts, open a PR for peer review. Nothing beats a second pair of eyes.

https://github.com/apache/storm/pull/281 (@nathanmarz vetoed, @d2r recommends closing)
https://github.com/apache/storm/pull/236 (@nathanmarz vetoed)
https://github.com/apache/storm/pull/352 (wating for @Lewuathe response)
https://github.com/apache/storm/pull/396 (committers seem to be in consensus against)
https://github.com/apache/storm/pull/406 (waiting for @ogorun response; related to STORM-650)
https://github.com/apache/storm/pull/407 (waiting for response from @wurstmeister; last update 02/2015)
https://github.com/apache/storm/pull/423 (last update 06/2015)
https://github.com/apache/storm/pull/432 (seems to be abandoned by @atdixon; last update 03/17/2015)
https://github.com/apache/storm/pull/442 (@nathanmarz vetoed)
https://github.com/apache/storm/pull/456 (needs committer review)
https://github.com/apache/storm/pull/459 (@knusbaum vetoed)
https://github.com/apache/storm/pull/471 (user issue?)
https://github.com/apache/storm/pull/475 (@revands2 vetoed)
https://github.com/apache/storm/pull/476 (+1 by @harshach, but unaddressed issue brought up by @knusbaum)
https://github.com/apache/storm/pull/477 (good idea, needs more committer input)
https://github.com/apache/storm/pull/478 (@ptgoetz commented 01/04/2015)
https://github.com/apache/storm/pull/489 (needs committer review)
https://github.com/apache/storm/pull/494 (stale; no response from contributor since 03/31/2015)
https://github.com/apache/storm/pull/510 (no response from @l03wn3, should probably close)
https://github.com/apache/storm/pull/511 (Bylaw change: requires VOTE thread)
https://github.com/apache/storm/pull/519 (Java 8 discussion)
https://github.com/apache/storm/pull/534 (waiting for upmerge from @danielcompton)
https://github.com/apache/storm/pull/553 (semi-negative feedback from committers)
https://github.com/apache/storm/pull/599 (@ptgoetz vetoed)
https://github.com/apache/storm/pull/600 (committer consensus that this should be closed)
https://github.com/apache/storm/pull/601 (some committer review, but no +1s; needs upmerge; last update 06/29/2015)
https://github.com/apache/storm/pull/606 (needs committer review)
https://github.com/apache/storm/pull/608 (@bourneagain requested it not be merged)
https://github.com/apache/storm/pull/623 (needs committer review)
https://github.com/apache/storm/pull/639 (needs committer review)
https://github.com/apache/storm/pull/640 (needs committer review)
https://github.com/apache/storm/pull/647 (@kishorvpatil vetoed)
https://github.com/apache/storm/pull/648 (+1'd by committer, needs upmerge)
https://github.com/apache/storm/pull/662 (Stale?; needs upmerge)
https://github.com/apache/storm/pull/668 (awaiting response from @redsanket; committer comments not fully addressed)
https://github.com/apache/storm/pull/685 (waiting for input from @itaifrenkel; last update 08/16/2015)

Thanks,

-Taylor