[GitHub] [doris] morningman commented on a diff in pull request #13231: [feature-wip](CN Node)Support compute node type

[GitBox <gi...@apache.org>]

morningman commented on code in PR #13231:
URL: https://github.com/apache/doris/pull/13231#discussion_r996457552


##########
be/src/common/config.h:
##########
@@ -872,6 +872,8 @@ CONF_mBool(enable_new_load_scan_node, "false");
 // Temp config. True to use new file scanner. Will remove after fully test.
 CONF_mBool(enable_new_file_scanner, "false");
 
+CONF_mString(be_node_type, "be");

Review Comment:
   how about `mixed`, `compute`, etc.
   And I think this is not a modifiable config, so it should be `CONF_String`



##########
fe/fe-core/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1788,4 +1788,6 @@ public class Config extends ConfigBase {
     @ConfField(mutable = false)
     public static int statistic_task_scheduler_execution_interval_ms = 60 * 1000;
 
+    @ConfField(mutable = true, masterOnly = false)
+    public static int backend_num_for_federation = 3;

Review Comment:
   Add some comment for this config



##########
fe/fe-core/src/main/java/org/apache/doris/resource/Tag.java:
##########
@@ -65,6 +66,7 @@ public class Tag implements Writable {
     public static final String VALUE_DEFAULT_CLUSTER = "default_cluster";
     public static final String VALUE_DEFAULT_TAG = "default";
     public static final String VALUE_INVALID_TAG = "invalid";
+    public static final String VALUE_NODE_TYPE_TAG = "be";

Review Comment:
   Actually, there are some predefined field like `TYPE_FUNCTION` and `VALUE_COMPUTATION`, they are supposed to do this feature.
   So I think we can use them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org