You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/03/30 23:56:50 UTC
[Bug 5397] New: RDNS_DYNAMIC hits on a PTR with 'static' in it.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
Summary: RDNS_DYNAMIC hits on a PTR with 'static' in it.
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: PC
OS/Version: Linux
Status: NEW
Severity: minor
Priority: P5
Component: Rules
AssignedTo: dev@spamassassin.apache.org
ReportedBy: mattheww@nmgi.com
Should a PTR with 'static' in it (by cox in this case) hit on this rule?
The ISP is trying to differentiate the static from the dynamic.
cox-DDD-DDD-DDD-DDD-static.coxinet.net is the format.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] [review] RDNS_DYNAMIC hits on a PTR with 'static' in it
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
Bug 5397 depends on bug 5564, which changed state.
Bug 5564 Summary: __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5564
What |Old Value |New Value
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |DUPLICATE
------- Additional Comments From jm@jmason.org 2007-07-30 13:33 -------
*** Bug 5564 has been marked as a duplicate of this bug. ***
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] [review] RDNS_DYNAMIC hits on a PTR with 'static' in it
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
------- Additional Comments From schulz@adi.com 2007-07-30 12:36 -------
Almost, but not quite. There is still a RDNS_DYNAMIC_ASAHI at the end of
meta RDNS_DYNAMIC. The patch for bug 5564 has the same problem.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] [review] RDNS_DYNAMIC hits on a PTR with 'static' in it
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From jm@jmason.org 2007-08-07 08:21 -------
now that rules can be committed C-T-R, applied to 3.2.x:
svn commit -m "bug 5397: RDNS_DYNAMIC should never fire on a PTR with 'static'
in it; thanks to Martin Blapp <mbr at freebsd.org>. bug 5563: RDNS_DYNAMIC
rules use order-dependent fields where it is unsafe to depend on this, fix. bug
5564: __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns, fix."
Sending rules/20_dynrdns.cf
Transmitting file data .
Committed revision 563519.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] [review] RDNS_DYNAMIC hits on a PTR with 'static' in it
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
------- Additional Comments From schulz@adi.com 2007-07-30 11:38 -------
> 3. __RDNS_DYNAMIC_ASAHI had been broken somewhere along the way -- it
> wasn't looking for the "rdns=" key of the X-Spam-Relays-Untrusted stanza.
While trying to apply the set of patches for bugs 5563, 5564 and this one,
I noticed that the RDNS_DYNAMIC_ASAHI stuff happened between the patch for
5563 and 5564. I can't find any bug that introduced it. Is the
RDNS_DYNAMIC_ASAHI rule intended to go into 3.2.3?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] [review] RDNS_DYNAMIC hits on a PTR with 'static' in it
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
BugsThisDependsOn| |5563, 5564
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] [review] RDNS_DYNAMIC hits on a PTR with 'static' in it
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4070 is|0 |1
obsolete| |
------- Additional Comments From jm@jmason.org 2007-07-30 12:08 -------
Created an attachment (id=4073)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4073&action=view)
redone fix for 3.2.x
here it is. unfortunately it requires that BOTH the patches from 5563 and 5564
be applied first :(
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] RDNS_DYNAMIC hits on a PTR with 'static' in it.
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
------- Additional Comments From mlathoud@b2b2c.ca 2007-04-19 07:07 -------
DDD-DD-DDD-DDD-static.enter-net.com
modemcableDDD.DD-DD-DD.static.videotron.ca
DDD-DDD-DDD-DDD.fix.sdsl.belcenter.be
I know it's only scoring 0.1 but it can be used for custom meta rules as well.
What about creating an __RDNS_STATIC rule and add && ! __RDNS_STATIC to
RDNS_DYNAMIC?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] [review] RDNS_DYNAMIC hits on a PTR with 'static' in it
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
------- Additional Comments From jm@jmason.org 2007-07-30 13:30 -------
(In reply to comment #10)
> Almost, but not quite. There is still a RDNS_DYNAMIC_ASAHI at the end of
> meta RDNS_DYNAMIC. The patch for bug 5564 has the same problem.
argh. good catch.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] [review] RDNS_DYNAMIC hits on a PTR with 'static' in it
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
------- Additional Comments From jm@jmason.org 2007-07-30 12:07 -------
(In reply to comment #7)
> While trying to apply the set of patches for bugs 5563, 5564 and this one,
> I noticed that the RDNS_DYNAMIC_ASAHI stuff happened between the patch for
> 5563 and 5564. I can't find any bug that introduced it. Is the
> RDNS_DYNAMIC_ASAHI rule intended to go into 3.2.3?
thanks for spotting this -- it turns out it's not in 3.2.x at all, so that part
of the patch was irrelevant for 3.2.x. unfortunately as a result that patch
wouldn't apply either :(
I'll post a new one...
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] [review] RDNS_DYNAMIC hits on a PTR with 'static' in it
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|RDNS_DYNAMIC hits on a PTR |[review] RDNS_DYNAMIC hits
|with 'static' in it. |on a PTR with 'static' in it
Status Whiteboard| |needs 2 votes for 3.2
------- Additional Comments From jm@jmason.org 2007-07-30 05:53 -------
applied to trunk:
: jm 108...; svn commit -m "bug 5397: RDNS_DYNAMIC should never fire on a PTR
with 'static' in it; thanks to Martin Blapp <mbr at freebsd.org>"
rules/20_dynrdns.cf
Sending rules/20_dynrdns.cf
Transmitting file data .
Committed revision 560954.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] [review] RDNS_DYNAMIC hits on a PTR with 'static' in it
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4073 is|0 |1
obsolete| |
------- Additional Comments From jm@jmason.org 2007-07-30 13:35 -------
Created an attachment (id=4074)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4074&action=view)
combined patch, including bug 5563 and 5564
ok, it's too much of a mess to have 3 separate patches; here's a combined
megapatch that includes the changes from bug 5563 and bug 5564.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] [review] RDNS_DYNAMIC hits on a PTR with 'static' in it
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |henry@stern.ca
Bug 5397 depends on bug 5563, which changed state.
Bug 5563 Summary: [review] 17 of the RDNS_DYNAMIC rules use order-dependent fields
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5563
What |Old Value |New Value
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |DUPLICATE
------- Additional Comments From jm@jmason.org 2007-07-30 13:33 -------
*** Bug 5563 has been marked as a duplicate of this bug. ***
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] RDNS_DYNAMIC hits on a PTR with 'static' in it.
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
------- Additional Comments From mlathoud@b2b2c.ca 2007-04-18 06:49 -------
Another one:
DDD.DDD-DDD-DD.static.qala.com.sg
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] RDNS_DYNAMIC hits on a PTR with 'static' in it.
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4049 is|0 |1
obsolete| |
------- Additional Comments From jm@jmason.org 2007-07-30 05:51 -------
Created an attachment (id=4070)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4070&action=view)
updated fix
here's a rewrite of that, fixing a few issues:
1. changes made recently in another bug meant that the original patch didn't
fit
2. it should just exempt cases where the last untrusted relay contained
"static", not any relay (since only the last relay is important)
3. __RDNS_DYNAMIC_ASAHI had been broken somewhere along the way -- it wasn't
looking for the "rdns=" key of the X-Spam-Relays-Untrusted stanza.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] RDNS_DYNAMIC hits on a PTR with 'static' in it.
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
------- Additional Comments From mbr@freebsd.org 2007-07-16 01:57 -------
Created an attachment (id=4049)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4049&action=view)
Don't classify hosts with 'static' or 'fixip' as dynamic hosts.
We use this patch to fix this issue.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5397] RDNS_DYNAMIC hits on a PTR with 'static' in it.
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5397
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.2.3
------- Additional Comments From jm@jmason.org 2007-07-16 10:26 -------
thanks Martin; makes sense
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.