You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/28 14:18:18 UTC
[GitHub] [flink] zentol opened a new pull request #11256:
[FLINK-16342][metrics][datadog] Remove mocking
zentol opened a new pull request #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256
- introduce timestamp factory instead of relying on static method
- introduce static package-private non-final flag for skipping api validation
The api key validation skip can be implemented in a nicer way once we ported the reporter to use factories/plugins, but for now this has to do.
And it's still better than throwing PowerMock at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#discussion_r385806016
##########
File path: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
##########
@@ -48,6 +48,8 @@
private static final int TIMEOUT = 3;
private static final ObjectMapper MAPPER = new ObjectMapper();
+ static boolean skipApiKeyValidation = false;
Review comment:
What about introducing a constructor `DatadogHttpClient(dgApiKey, dgProxyHost, dgProxyPort, boolean validateApiKey)` instead of this static field? It is also not perfect but I think it is a bit better than having this static field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#discussion_r385771913
##########
File path: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
##########
@@ -48,6 +48,8 @@
private static final int TIMEOUT = 3;
private static final ObjectMapper MAPPER = new ObjectMapper();
+ static boolean skipApiKeyValidation = false;
Review comment:
or `@VisibleForTesting`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#discussion_r385811793
##########
File path: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
##########
@@ -48,6 +48,8 @@
private static final int TIMEOUT = 3;
private static final ObjectMapper MAPPER = new ObjectMapper();
+ static boolean skipApiKeyValidation = false;
Review comment:
I would go with that solution once factories are in place; as it stands we would need 2 constructors; one with the arguments, one no-arg constructor for reflection purposes (which would be detected as being unused), and I don't want to have to watch out for someone removing the constructor because he thought it's not used anyway, or migrate tests towards the new "convenient" constructor at which point we lose test coverage of runtime paths.
I know it's super icky and Ideally we get rid of the reflection approach soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#issuecomment-592539207
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151036652",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151055624",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5756",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
}, {
"hash" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5763",
"triggerID" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"triggerType" : "PUSH"
}, {
"hash" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151141904",
"triggerID" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1691f7d4b7591336d2808dc78a15ea33bec5d054 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151141904) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5763)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#issuecomment-592539207
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151036652",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "CANCELED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151055624",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5756",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
}, {
"hash" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5763",
"triggerID" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"triggerType" : "PUSH"
}, {
"hash" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151141904",
"triggerID" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c908cd4786275b8734d79d42ab9f26dc4c1f78f2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/151055624) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5756)
* 1691f7d4b7591336d2808dc78a15ea33bec5d054 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151141904) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5763)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#issuecomment-592539207
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151036652",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68d419a8e3a2738bda013ef0e2888f9eae7c3031 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151036652) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743)
* c908cd4786275b8734d79d42ab9f26dc4c1f78f2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#issuecomment-592539207
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151036652",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151055624",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5756",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
}, {
"hash" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c908cd4786275b8734d79d42ab9f26dc4c1f78f2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151055624) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5756)
* 1691f7d4b7591336d2808dc78a15ea33bec5d054 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#issuecomment-592539207
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151036652",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68d419a8e3a2738bda013ef0e2888f9eae7c3031 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151036652) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#issuecomment-592539207
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68d419a8e3a2738bda013ef0e2888f9eae7c3031 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#issuecomment-592539207
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151036652",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151055624",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5756",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
}, {
"hash" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5763",
"triggerID" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"triggerType" : "PUSH"
}, {
"hash" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151141904",
"triggerID" : "1691f7d4b7591336d2808dc78a15ea33bec5d054",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1691f7d4b7591336d2808dc78a15ea33bec5d054 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151141904) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5763)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#issuecomment-592539207
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151036652",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151055624",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5756",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c908cd4786275b8734d79d42ab9f26dc4c1f78f2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151055624) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5756)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#issuecomment-592539207
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "CANCELED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151036652",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151055624",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
}, {
"hash" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5756",
"triggerID" : "c908cd4786275b8734d79d42ab9f26dc4c1f78f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68d419a8e3a2738bda013ef0e2888f9eae7c3031 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/151036652) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743)
* c908cd4786275b8734d79d42ab9f26dc4c1f78f2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151055624) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5756)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#discussion_r385955801
##########
File path: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
##########
@@ -48,6 +48,8 @@
private static final int TIMEOUT = 3;
private static final ObjectMapper MAPPER = new ObjectMapper();
+ static boolean skipApiKeyValidation = false;
Review comment:
ooooooooooooooooooooooooooohhhhh....this is the _client_...yeah then we should totally do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#discussion_r385771163
##########
File path: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
##########
@@ -48,6 +48,8 @@
private static final int TIMEOUT = 3;
private static final ObjectMapper MAPPER = new ObjectMapper();
+ static boolean skipApiKeyValidation = false;
Review comment:
shall we add a comment to mention that this option is for testing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#issuecomment-592533683
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 68d419a8e3a2738bda013ef0e2888f9eae7c3031 (Fri Feb 28 14:20:51 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11256:
[FLINK-16342][metrics][datadog] Remove mocking
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11256: [FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#issuecomment-592539207
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151036652",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
}, {
"hash" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743",
"triggerID" : "68d419a8e3a2738bda013ef0e2888f9eae7c3031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68d419a8e3a2738bda013ef0e2888f9eae7c3031 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151036652) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5743)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services