You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/07/08 02:12:27 UTC
[GitHub] [httpcomponents-client] garydgregory opened a new pull request #238: 4.5.x deduplicate redundant immutable objects
garydgregory opened a new pull request #238:
URL: https://github.com/apache/httpcomponents-client/pull/238
Reuse singleton instances of immutable instances.
Static singletons finals are called INSTANCE when there is only one instance possible and DEFAULT when more than one instance can be constructed with parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on pull request #238: 4.5.x deduplicate redundant immutable objects
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #238:
URL: https://github.com/apache/httpcomponents-client/pull/238#issuecomment-655327741
I wouldn't touch 4.x anymore with so many changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] garydgregory commented on pull request #238: 4.5.x deduplicate redundant immutable objects
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #238:
URL: https://github.com/apache/httpcomponents-client/pull/238#issuecomment-655490435
Hi All,
I respectfully disagree for the following reason with the side note that I do not care if we use this in a 4.5.x or 4.6.x:
Most of the code path in the software stacks I work with use HC 4. I've managed to migrate a small pile of code to HC 5 (good for me) and I plan for new projects to use HC 5. But, for the foreseeable future, HC 4 is going to live in my software stacks, either directly or transitively, there is no way around that, my team and I just maintain and develop a lot of code. While not perfect or desirable, I must consider for my team both HC 4 and HC 5 as active for now. Yes, eventually HC 5 will be everywhere for me, but not now, and not this year even, who knows when.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] garydgregory edited a comment on pull request #238: 4.5.x deduplicate redundant immutable objects
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #238:
URL: https://github.com/apache/httpcomponents-client/pull/238#issuecomment-655490435
Hi All,
I respectfully disagree for the following reason with the side note that I do not care if we use this in a 4.5.x or 4.6.x:
Most of the code path in the software stacks I work with use HC 4. I've managed to migrate a small pile of code to HC 5 (good for me) and I plan for new projects to use HC 5. But, for the foreseeable future, HC 4 is going to live in my software stacks, either directly or transitively, there is no way around that, my team and I just maintain and develop a lot of code. While not perfect or desirable, I must consider for my team both HC 4 and HC 5 as active for now. Yes, eventually HC 5 will be everywhere for me, but not now, and not this year even, who knows when.
PS: I will provide a similar patch for HC 5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on pull request #238: 4.5.x deduplicate redundant immutable objects
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #238:
URL: https://github.com/apache/httpcomponents-client/pull/238#issuecomment-655491819
@garydgregory We have a huge product by Siemens PLM which used Commons HttpClient 3. x until last year. ;-)
I understand that you want to have code consistent if possible. I would propose to release 4.5.x if there are unreleased changes. Create branch 4.6.x and re-review this PR for this new branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #238: 4.5.x deduplicate redundant immutable objects
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #238:
URL: https://github.com/apache/httpcomponents-client/pull/238#issuecomment-655349349
@garydgregory I agree with @michael-o I would not touch 4.x any longer beyond major bug fixes unless we want to initiate 4.6.x development cycle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c closed pull request #238: 4.5.x deduplicate redundant immutable objects
Posted by GitBox <gi...@apache.org>.
ok2c closed pull request #238:
URL: https://github.com/apache/httpcomponents-client/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org