[GitHub] [calcite] guiyanakuang edited a comment on pull request #2632: [MINOR] Optimization of official website documentation

[GitBox <gi...@apache.org>]

guiyanakuang edited a comment on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-989976407


   > @guiyanakuang The changes about code wrapping and scrollability are a good idea but they are more useful if the apply everywhere. After playing a bit and resizing the window I found other tables that were overflowing. I pushed a few commits ([53c9744](https://github.com/apache/calcite/commit/53c974496b267ae329643fd0d995e87bcfdbf123), [d7b2211](https://github.com/apache/calcite/commit/d7b2211b924c1f7286a4ff93b0380edf7246fe2c), [e299b4b](https://github.com/apache/calcite/commit/e299b4b0516b9ddea8a7562bc48391232efc6e39)) along these lines. What do you think?
   
   My thinking when I committed this pr was to address the most crowded tables and to ensure that changes were minimised. Indeed the rest of the tables may overflow even after adjusting the width. If you don't mind a line break in the code, I'd agree to modify the css of the table.  `overflow-x: auto;`  looks better.
   
   If you don't mind, I'll use my work computer tomorrow to verify the results, I'm not comfortable compiling jekyll right now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org