[jira] [Comment Edited] (FLINK-6805) Flink Cassandra connector dependency on Netty disagrees with Flink

["Michael Fong (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120885#comment-16120885 ] 

Michael Fong edited comment on FLINK-6805 at 8/11/17 2:50 AM:
--------------------------------------------------------------

Thanks for your comment, [~Zentol], 

One question above all, since Flink shaded netty would rename the classes FQN to specified class path, and would thus stick with the netty implementation to 4.0.27 as required for Flink. Would there be any need to consolidate all other netty version used in other libraries, in this cases, cassandra-driver-core uses netty 4.0.33

Could you please share the example you mentioned for guava, and how would that prevent from potential conflict in future upgrade.  Thanks.

Regards,

Michael Fong


was (Author: mcfongtw):
Thanks for your comment, [~Zentol], 

I see the point of Flink's shaded netty and relocating original netty to Flink shaded netty dependency, but I don't quite get the point 2). Could you please share the example you mentioned for guava, and how would that prevent from potential conflict in future upgrade if it is not using shading approach.  Thanks.

Regards,

Michael Fong

> Flink Cassandra connector dependency on Netty disagrees with Flink
> ------------------------------------------------------------------
>
>                 Key: FLINK-6805
>                 URL: https://issues.apache.org/jira/browse/FLINK-6805
>             Project: Flink
>          Issue Type: Bug
>          Components: Cassandra Connector
>    Affects Versions: 1.3.0, 1.2.1
>            Reporter: Shannon Carey
>             Fix For: 1.4.0
>
>
> The Flink Cassandra connector has a dependency on Netty libraries (via promotion of transitive dependencies by the Maven shade plugin) at version 4.0.33.Final, which disagrees with the version included in Flink of 4.0.27.Final which is included & managed by the parent POM via dependency on netty-all.
> Due to use of netty-all, the dependency management doesn't take effect on the individual libraries such as netty-handler, netty-codec, etc.
> I suggest that dependency management of Netty should be added for all Netty libraries individually (netty-handler, etc.) so that all Flink modules use the same version, and similarly I suggest that exclusions be added to the quickstart example POM for the individual Netty libraries so that fat JARs don't include conflicting versions of Netty.
> It seems like this problem started when FLINK-6084 was implemented: transitive dependencies of the flink-connector-cassandra were previously omitted, and now that they are included we must make sure that they agree with the Flink distribution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)