[jira] [Commented] (METRON-1003) ParserUtil parses dates incorrect

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060922#comment-16060922 ] 

ASF GitHub Bot commented on METRON-1003:
----------------------------------------

GitHub user bjigmp opened a pull request:

    https://github.com/apache/metron/pull/623

    METRON-1003 ParserUtil parses dates incorrect

    ## Contributor Comments
    org.apache.metron.parsers.utils.ParserUtils.convertToEpoch parses dates incorrectly.
    It invokes method "get(Calendar.MONTH)" from  Calendar object but not increase result value.
    According to documentation months are started from 0: https://docs.oracle.com/javase/7/docs/api/java/util/Calendar.html#MONTH)
    
    **Steps to reproduce:**
    Import ParserUtils and call convertToEpoch method with any parameters.
    For example:
    `Long ts = ParserUtils.convertToEpoch("Mar", "2", "05:24:39", true);`
    Method will return **1486013079000**. And after converting to human format: 
    **Thu, 02 Feb 2017 05:24:39 GMT**
    Got "Feb" instead of "Mar"
    
    Example of code for manual testing:
    ```
    import org.apache.metron.parsers.utils.ParserUtils;
    import java.text.ParseException;
    
    class Main {
            public static void main(String[] argv) throws ParseException {
                    Long ts = ParserUtils.convertToEpoch("Mar", "2", "05:24:39", true);
                    System.out.println(ts);
            }
    }
    ```
    To run:
    ```
    javac -cp ~/incubator-metron/metron-platform/metron-parsers/target/classes/  Main.java
    java -classpath ~/incubator-metron/metron-platform/metron-parsers/target/classes/:. Main
    ```
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjigmp/incubator-metron METRON-1003_ParseUtilFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/623.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #623
    
----
commit 243bddc1c211f81776c9143125dc2feec3ac5f47
Author: Vladimir Sh <bj...@users.noreply.github.com>
Date:   2017-06-22T13:44:49Z

    METRON-1003. Fix date converting. Added unit test for ParserUtils

----


> ParserUtil parses dates incorrect
> ---------------------------------
>
>                 Key: METRON-1003
>                 URL: https://issues.apache.org/jira/browse/METRON-1003
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Vladimir
>            Priority: Minor
>
> ParserUtils class has method convertToEpoch that takes month, day and time (as strings), parses it and returns milliseconds since epoch.
> Month expected in "MMM" format (i.e. "Jun")
> Month is parsed and then it is tried to get int value as:
> {code}
> String month = String.valueOf(cal.get(Calendar.MONTH));
> {code}
> But according to documentation (see https://docs.oracle.com/javase/7/docs/api/java/util/Calendar.html#MONTH) months start from 0.
> So this method returns incorrect value.
> This method should be refactored, but would be great to fix it and write some tests before.
> This is minor bug as this method is used in FireEye parser only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)