You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/01 10:07:35 UTC

[GitHub] [airflow] zhongjiajie commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…

zhongjiajie commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#discussion_r386094551
 
 

 ##########
 File path: airflow/www/templates/airflow/dag.html
 ##########
 @@ -33,7 +33,8 @@ <h3 class="pull-left">
         <span style='color:#AAA;'>SUBDAG: </span> <span> {{ dag.dag_id }}</span>
       {% else %}
         <input id="pause_resume" dag_id="{{ dag.dag_id }}" type="checkbox" {{ "checked" if not dag.is_paused else "" }} data-toggle="toggle" data-size="mini" method="post">
-        <span style='color:#AAA;'>DAG: </span> <span> {{ dag.dag_id }}</span> <small class="text-muted"> {{ dag.description }} </small>
+        <span style='color:#AAA;'>DAG: </span> <span> {{ dag.dag_id }}</span>
+        <small class="text-muted"> description: {{ dag.description[0:150] + '...' if dag.description and dag.description|length > 150 else dag.description }} </small>
 
 Review comment:
   I want to keep same UI behavior and view, so I did it. Do you think we should hide text

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services