[GitHub] metron pull request #1180: removing missleading and unnecessary @Input annot...

[tiborm <gi...@git.apache.org>]

GitHub user tiborm opened a pull request:

    https://github.com/apache/metron/pull/1180

    removing missleading and unnecessary @Input annotations

    ## Contributor Comments
    The following fields are annotated as inputs fields in pcap-panel, but actually, they don't.
     
    @Input pdml:Pdml=null;
    @Input pcapRequest:PcapRequest;
    @Input resetPaginationForSearch:boolean;
     
    The current state of the code is misleading and makes harder to understand the actual behaviour of the panel component.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tiborm/metron METRON-1759-wrong-input-anotations

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1180
    
----
commit 412d8b4ea1d320aa7960cedd98226944257a78b2
Author: tiborm <ti...@...>
Date:   2018-08-31T08:37:04Z

    removing missleading and unnecessary @Input annotations

----


---

[GitHub] metron issue #1180: METRON-1759: PCAP UI: Removing wrong Input annotations f...

[nickwallen <gi...@git.apache.org>]

Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/1180
  
    +1 by inspection. Thanks!


---

[GitHub] metron issue #1180: METRON-1759: PCAP UI: Removing wrong Input annotations f...

[sardell <gi...@git.apache.org>]

Github user sardell commented on the issue:

    https://github.com/apache/metron/pull/1180
  
    +1. Tested on full-dev, and everything works as expected. Good catch, @tiborm.


---

[GitHub] metron issue #1180: METRON-1759: PCAP UI: Removing wrong Input annotations f...

[ruffle1986 <gi...@git.apache.org>]

Github user ruffle1986 commented on the issue:

    https://github.com/apache/metron/pull/1180
  
    +1. Nice catch! 🍻 


---

[GitHub] metron pull request #1180: METRON-1759: PCAP UI: Removing wrong Input annota...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/metron/pull/1180


---