You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/11 21:54:27 UTC

[GitHub] [geode-native] gaussianrecurrence opened a new pull request #764: GEODE-8756: Fix CacheableString::objectSize

gaussianrecurrence opened a new pull request #764:
URL: https://github.com/apache/geode-native/pull/764


     - objectSize was not taking into account null-terminator character,
       which as of C++11, as stated in ยง 21.4.7.1, should be included at
       the end of the same string character sequence.
     - Also, in those cases in which SSO applied, the returned size was
       higher than the actual one.
     - A parametrized UT was added to check objectSize is returning the
       right size. Note that no fixed sizes are part of such test, given
       that each std::string implementation could have a different SSO
       size.
     - Added a new class called size_tracking_allocator, which is a custom
       allocator used to track the size STL objects.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] gaussianrecurrence commented on pull request #764: GEODE-8756: Fix CacheableString::objectSize

Posted by GitBox <gi...@apache.org>.
gaussianrecurrence commented on pull request #764:
URL: https://github.com/apache/geode-native/pull/764#issuecomment-803158885


   As STL objects depends directly on which specific implementation is choosen, and there is no standarization regarding it, sadly there is no way to guarantee that introducing this change won't blow up in the future. Closing the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] gaussianrecurrence closed pull request #764: GEODE-8756: Fix CacheableString::objectSize

Posted by GitBox <gi...@apache.org>.
gaussianrecurrence closed pull request #764:
URL: https://github.com/apache/geode-native/pull/764


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org