[jira] Updated: (SOLR-2288) clean up compiler warnings

["Hoss Man (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-2288:
---------------------------

    Attachment: warning.cleanup.patch

here's a patch i worked up a bit today ... i started by trying to focus on the facet code, and then started bouncing around to areas where NamedList was being used w/o a bounds on the generic, but i know even with that i'm missing some.

i'm posting this here in the hoops that the generics policeman (et. al.) will help give it a once over review -- assuming the general approach taken here doesn't raise any red flags with anyone in the next day or so, i'll commit and continue on with similar easy fixes arround the tree w/o bothering to post patches to jira (since this type of patch tends to get stale quickly and leads to a lot of pain trying to keep up to date)


> clean up compiler warnings
> --------------------------
>
>                 Key: SOLR-2288
>                 URL: https://issues.apache.org/jira/browse/SOLR-2288
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: warning.cleanup.patch
>
>
> there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones)
> Using this issue to track related commits
> The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way;
> * fix generic declarations
> * add SuppressWarning anotation if it's safe in context

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org