[GitHub] [airflow] jcarless opened a new pull request #8441: [AIRFLOW-7111] Add generate_presigned_url method to S3Hook

[GitBox <gi...@apache.org>]

jcarless opened a new pull request #8441: [AIRFLOW-7111] Add generate_presigned_url method to S3Hook
URL: https://github.com/apache/airflow/pull/8441
 
 
   Boto3 generate_presigned_url exposed to S3Hook.
   ---
   
   - [ x ] Description above provides context of the change
   - [ x ] Unit tests coverage for changes (not needed for documentation changes)
   - [ x ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ x ] Relevant documentation is updated including usage instructions.
   - [ x ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #8441: [AIRFLOW-7111] Add generate_presigned_url method to S3Hook

[GitBox <gi...@apache.org>]

potiuk commented on issue #8441: [AIRFLOW-7111] Add generate_presigned_url method to S3Hook
URL: https://github.com/apache/airflow/pull/8441#issuecomment-616206596
 
 
   Looks good but the static checks are failing at flake8. I recommend installing pre-commit @jcarless !

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services