You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "terrytlu (via GitHub)" <gi...@apache.org> on 2024/09/18 11:00:21 UTC
[PR] HIVE-28526 may produce null pointer when struct type value is null [hive]
terrytlu opened a new pull request, #5454:
URL: https://github.com/apache/hive/pull/5454
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
null pointer check
### Why are the changes needed?
it is a bug.
### Does this PR introduce _any_ user-facing change?
No
### Is the change a dependency upgrade?
No
### How was this patch tested?
sql test, add ql/src/test/queries/clientpositive/struct_null_select.q
create table test_struct
(
f1 string,
demo_struct struct<f1:string,f2:string,f3:string>,
datestr string
);
insert into test_struct(f1, datestr) select 'test_f1','datestr_1';
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28526 may produce null pointer when struct type value is null [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5454:
URL: https://github.com/apache/hive/pull/5454#issuecomment-2358326643
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5454) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5454&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5454&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5454&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5454&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5454&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5454)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28526 may produce null pointer when struct type value is null [hive]
Posted by "difin (via GitHub)" <gi...@apache.org>.
difin commented on code in PR #5454:
URL: https://github.com/apache/hive/pull/5454#discussion_r1765724444
##########
ql/src/test/queries/clientpositive/struct_null_select.q:
##########
@@ -0,0 +1,10 @@
+create table test_struct
Review Comment:
The name of the q-test is a little bit confusing to me because the test doesn't seem to select any nulls.
Also, is the .q.out file is missing for this new test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28526 may produce null pointer when struct type value is null [hive]
Posted by "difin (via GitHub)" <gi...@apache.org>.
difin commented on code in PR #5454:
URL: https://github.com/apache/hive/pull/5454#discussion_r1765724444
##########
ql/src/test/queries/clientpositive/struct_null_select.q:
##########
@@ -0,0 +1,10 @@
+create table test_struct
Review Comment:
The filename of the q-test is a little bit confusing to me because the test doesn't seem to select any nulls.
Also, is the .q.out file missing for this new test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28526 may produce null pointer when struct type value is null [hive]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5454: HIVE-28526 may produce null pointer when struct type value is null
URL: https://github.com/apache/hive/pull/5454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28526 may produce null pointer when struct type value is null [hive]
Posted by "ngsg (via GitHub)" <gi...@apache.org>.
ngsg commented on PR #5454:
URL: https://github.com/apache/hive/pull/5454#issuecomment-2456141069
I failed reproduce the problem with your test on TestMiniLlapLocalCliDriver, and it seems that this issue is fixed by HIVE-27690. Could you check and share your test environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28526 may produce null pointer when struct type value is null [hive]
Posted by "difin (via GitHub)" <gi...@apache.org>.
difin commented on code in PR #5454:
URL: https://github.com/apache/hive/pull/5454#discussion_r1765724444
##########
ql/src/test/queries/clientpositive/struct_null_select.q:
##########
@@ -0,0 +1,10 @@
+create table test_struct
Review Comment:
The name of the q-test is a little bit confusing to me because the test doesn't seem to select any nulls.
Also, is the .q.out file missing for this new test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28526 may produce null pointer when struct type value is null [hive]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5454:
URL: https://github.com/apache/hive/pull/5454#issuecomment-2571451927
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org