You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@impala.apache.org by "Bikramjeet Vig (JIRA)" <ji...@apache.org> on 2017/10/30 18:17:00 UTC

[jira] [Resolved] (IMPALA-6123) test_inline_view_limit fails in exhaustive tests

     [ https://issues.apache.org/jira/browse/IMPALA-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bikramjeet Vig resolved IMPALA-6123.
------------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.11.0

https://github.com/apache/incubator-impala/commit/f11181cbe5a7eaa3ae16bfb6a60ab9e200e37d39

IMPALA-6123: Fix column order of a query test in test_inline_view_limit

Currently a "select *" query in test_inline_view_limit fails during
exhaustive testing because Impala returns columns from HBase tables
in a different order (IMPALA-886) than the one expected. This fix
ensures the column order is consistent by specifying the output
columns in the right order in the select query.

Testing:
Tested locally, with and without exhaustive exploration strategy.

Change-Id: I11667872b8788a8b0040bf9252bf07b987b5d330
Reviewed-on: http://gerrit.cloudera.org:8080/8409
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins

> test_inline_view_limit fails in exhaustive tests
> ------------------------------------------------
>
>                 Key: IMPALA-6123
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6123
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 2.11.0
>            Reporter: Lars Volker
>            Assignee: Bikramjeet Vig
>            Priority: Blocker
>              Labels: broken-build
>             Fix For: Impala 2.11.0
>
>
> The failing test was added in [this change|https://gerrit.cloudera.org/#/c/8196/] for IMPALA-4236. I ran the test locally and it passes in core exploration mode, but fails in exhaustive. My local branch was at commit {{30629fdea5 IMPALA-2758: Remove BufferedTupleStream::GetRows (2017-10-27 22:15 GMT) <Tianyi Wang>}}.
> [~bikramjeet.vig] - Can you have a look?
> Here is the output from running it locally, below is what I saw in a private Jenkins build.
> {noformat}
> -- executing against localhost:21000
> select count(*) from (
>   select id from
>     (select id from functional.alltypes limit 7300) v1
>   where id >= 0) v2;
> -- executing against localhost:21000
> select * from (select * from alltypes order by id limit 20) t1 where int_col <100 limit 5;
> FAILED-- closing connection to: localhost:21000
> ====================================== short test summary info =======================================
> FAIL tests/query_test/test_queries.py::TestQueries::()::test_inline_view_limit[exec_option: {'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 0, 'disable_codegen': True, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: hbase/none]
> ============================================== FAILURES ==============================================
>  TestQueries.test_inline_view_limit[exec_option: {'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 0, 'disable_codegen': True, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: hbase/none]
> tests/query_test/test_queries.py:108: in test_inline_view_limit
>     self.run_test_case('QueryTest/inline-view-limit', vector)
> tests/common/impala_test_suite.py:424: in run_test_case
>     self.__verify_results_and_errors(vector, test_section, result, use_db)
> tests/common/impala_test_suite.py:297: in __verify_results_and_errors
>     replace_filenames_with_placeholder)
> tests/common/test_result_verifier.py:348: in verify_raw_results
>     verify_results(expected_types, actual_types, order_matters=True)
> tests/common/test_result_verifier.py:258: in verify_results
>     assert expected_results == actual_results
> E   assert ['INT', 'BOOL...'BIGINT', ...] == ['INT', 'BIGIN... 'FLOAT', ...]
> E     At index 1 diff: 'BOOLEAN' != 'BIGINT'
> E     Full diff:
> E     ['INT',
> E     +  'BIGINT',
> E     'BOOLEAN',
> E     +  'STRING',
> E     +  'DOUBLE',
> E     +  'FLOAT',
> E     -  'TINYINT',
> E     ?   ----
> E     +  'INT',
> E     +  'INT',
> E     'SMALLINT',
> E     -  'INT',
> E     -  'BIGINT',
> E     -  'FLOAT',
> E     -  'DOUBLE',
> E     -  'STRING',
> E     'STRING',
> E     'TIMESTAMP',
> E     -  'INT',
> E     +  'TINYINT',
> E     ?   ++++
> E     'INT']
> !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
> ======================== 2562 tests deselected by '-ktest_inline_view_limit' =========================
> {noformat}
> {noformat}
> 14:45:20 -- executing against localhost:21000
> 14:45:20 select * from (select * from alltypes order by id limit 20) t1 where int_col <100 limit 5;
> 14:45:20 
> 14:45:20  TestHdfsQueries.test_inline_view_limit[exec_option: {'disable_codegen_rows_threshold': 0, 'disable_codegen': True, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 100, 'batch_size': 0, 'num_nodes': 0} | table_format: hbase/none] 
> 14:45:20 [gw2] linux2 -- Python 2.6.6 /data/jenkins/workspace/impala-asf-master-exhaustive/repos/Impala/bin/../infra/python/env/bin/python
> 14:45:20 query_test/test_queries.py:108: in test_inline_view_limit
> 14:45:20     self.run_test_case('QueryTest/inline-view-limit', vector)
> 14:45:20 common/impala_test_suite.py:424: in run_test_case
> 14:45:20     self.__verify_results_and_errors(vector, test_section, result, use_db)
> 14:45:20 common/impala_test_suite.py:297: in __verify_results_and_errors
> 14:45:20     replace_filenames_with_placeholder)
> 14:45:20 common/test_result_verifier.py:348: in verify_raw_results
> 14:45:20     verify_results(expected_types, actual_types, order_matters=True)
> 14:45:20 common/test_result_verifier.py:258: in verify_results
> 14:45:20     assert expected_results == actual_results
> 14:45:20 E   assert ['INT', 'BOOL...'BIGINT', ...] == ['INT', 'BIGIN... 'FLOAT', ...]
> 14:45:20 E     At index 1 diff: 'BOOLEAN' != 'BIGINT'
> 14:45:20 E     Use -v to get the full diff
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)