You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/15 10:37:54 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #34886: [SPARK-37632][PYTHON] Drop code that targets Python < 3.7

HyukjinKwon commented on a change in pull request #34886:
URL: https://github.com/apache/spark/pull/34886#discussion_r769500438



##########
File path: python/pyspark/pandas/typedef/typehints.py
##########
@@ -585,17 +580,12 @@ def infer_return_type(f: Callable) -> Union[SeriesType, DataFrameType, ScalarTyp
         return SeriesType(dtype, spark_type)
 
     # Note that, DataFrame type hints will create a Tuple.
-    # Python 3.6 has `__name__`. Python 3.7 and 3.8 have `_name`.

Review comment:
       There's similar instance at `python/pyspark/sql/pandas/typehints.py` too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org