You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Li Can (Jira)" <ji...@apache.org> on 2023/01/03 07:34:00 UTC

[jira] [Comment Edited] (KYLIN-5361) suggest set email content from hard code to configurable files

    [ https://issues.apache.org/jira/browse/KYLIN-5361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653840#comment-17653840 ] 

Li Can edited comment on KYLIN-5361 at 1/3/23 7:33 AM:
-------------------------------------------------------

1.Look at the pics with 16727 prefix, these pics show the tests of new mail function, these mails contents can be modified in files not in hard code.

2.Below configs are mail properties:

###MAIL ###

If true, will send email notification: succeed, error, discard;
kylin.job.notification-enabled=true {color:#ff0000}(main switch){color}
#kylin.job.notification-mail-enable-starttls=true
kylin.job.notification-mail-host=smtp.office365.com

#kylin.job.notification-mail-port=587
kylin.job.notification-mail-username=_kylin_test
kylin.job.notification-mail-password=
[kylin.job.notification-mail-sender=kylin@example.com|mailto:kylin.job.notification-mail-sender=kylin@example.com]

[kylin.job.notification-admin-emails=kylin@example.com|mailto:kylin.job.notification-admin-emails=kylin@example.com]

kylin.job.notification-enable-states=Succeed,Error,Discard {color:#ff0000}(notify states, split with ',' and First letter must be capital){color}
#kylin.capacity.notification-emails=
#notify empty data
#kylin.job.notification-on-empty-data-load=false
#notify source records change
#kylin.job.notification-on-source-records-change=false
#notify metadata persist
#kylin.job.notification-on-metadata-persist=false
#capacity threshold only invoked in test case
#kylin.capacity.notification-enabled=false


was (Author: JIRAUSER294457):
1.Look at the pics with 16727 prefix, these pics show the tests of new mail function, these mails contents can be modified in files not in hard code.

2.Below configs are mail properties:

### MAIL ###
# If true, will send email notification: succeed, error, discard;
kylin.job.notification-enabled=true {color:#FF0000}(main switch){color}
#kylin.job.notification-mail-enable-starttls=true
kylin.job.notification-mail-host=smtp.office365.com

#kylin.job.notification-mail-port=587
kylin.job.notification-mail-username=_kylin_test
kylin.job.notification-mail-password=
[kylin.job.notification-mail-sender=kylin@example.com|mailto:kylin.job.notification-mail-sender=kylin@example.com]

[kylin.job.notification-admin-emails=kylin@example.com|mailto:kylin.job.notification-admin-emails=kylin@example.com]

kylin.job.notification-enable-states=Succeed,Error,Discard {color:#FF0000}(notify states, split with ',' and First letter must be capital){color}
#kylin.capacity.notification-emails=
#notify empty data
#kylin.job.notification-on-empty-data-load=false
#notify source records change
#kylin.job.notification-on-source-records-change=false
#notify metadata persist
#kylin.job.notification-on-metadata-persist=false
#capacity threshold only invoked in test case
#kylin.capacity.notification-enabled=false

> suggest set email content from hard code to  configurable  files
> ----------------------------------------------------------------
>
>                 Key: KYLIN-5361
>                 URL: https://issues.apache.org/jira/browse/KYLIN-5361
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Others
>    Affects Versions: 5.0-alpha
>            Reporter: Li Can
>            Assignee: Li Can
>            Priority: Major
>             Fix For: 5.0-alpha
>
>         Attachments: 1672730611150.jpg, 1672730640332.jpg, 1672730668472.jpg, 1672730705781.jpg, 1672730728444.jpg, emailcontent.png
>
>
> These all email information cannot configure by users with comfortable way, only way just to change the hard code, this method is not suitable for diversity customers.
> So we need adjust the hard code to configurable files, and set relative path to read the file, and then the users can easily modify the contents with the files rather than hard code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)