You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael Gibney (Created) (JIRA)" <ji...@apache.org> on 2011/11/03 17:07:32 UTC

[jira] [Created] (SOLR-2873) StreamingUpdateSolrServer does not provide public access to shutdown ExecutorService scheduler

StreamingUpdateSolrServer does not provide public access to shutdown ExecutorService scheduler
----------------------------------------------------------------------------------------------

                 Key: SOLR-2873
                 URL: https://issues.apache.org/jira/browse/SOLR-2873
             Project: Solr
          Issue Type: Bug
          Components: clients - java
    Affects Versions: 4.0
         Environment: N/A
            Reporter: Michael Gibney
            Priority: Minor
             Fix For: 4.0


Applications do not exit until the StreamingUpdateSolrServer ExecutorService threads have died.  Currently, with no way to manually shut down the ExecutorService, an application that has completed execution will hang for 60s waiting for the keepAlive time on the pooled runner threads to expire.  This could be addressed by adding a single method to StreamingUpdateSolrServer:
{code:borderStyle=solid}
public void shutdown() {
    scheduler.shutdown();
}
{code} 


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (SOLR-2873) StreamingUpdateSolrServer does not provide public access to shutdown ExecutorService scheduler

Posted by "Sami Siren (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sami Siren resolved SOLR-2873.
------------------------------

    Resolution: Invalid

Today there is a shutdown method that calls scheduler.shutdown(), perhaps it was added in some other issue.
                
> StreamingUpdateSolrServer does not provide public access to shutdown ExecutorService scheduler
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-2873
>                 URL: https://issues.apache.org/jira/browse/SOLR-2873
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 4.0
>         Environment: N/A
>            Reporter: Michael Gibney
>            Priority: Minor
>             Fix For: 4.0
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Applications do not exit until the StreamingUpdateSolrServer ExecutorService threads have died.  Currently, with no way to manually shut down the ExecutorService, an application that has completed execution will hang for 60s waiting for the keepAlive time on the pooled runner threads to expire.  This could be addressed by adding a single method to StreamingUpdateSolrServer:
> {code:borderStyle=solid}
> public void shutdown() {
>     scheduler.shutdown();
> }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-2873) StreamingUpdateSolrServer does not provide public access to shutdown ExecutorService scheduler

Posted by "Lance Norskog (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145178#comment-13145178 ] 

Lance Norskog commented on SOLR-2873:
-------------------------------------

Also, you will find a design feature in various places: finalize complains if the object not already shut down. You can see how this works in SolrIndexWriter:finalize().

This design pattern enforces clean programming; but it will add an error message to every existing program that uses SUSS :(.
                
> StreamingUpdateSolrServer does not provide public access to shutdown ExecutorService scheduler
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-2873
>                 URL: https://issues.apache.org/jira/browse/SOLR-2873
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 4.0
>         Environment: N/A
>            Reporter: Michael Gibney
>            Priority: Minor
>             Fix For: 4.0
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Applications do not exit until the StreamingUpdateSolrServer ExecutorService threads have died.  Currently, with no way to manually shut down the ExecutorService, an application that has completed execution will hang for 60s waiting for the keepAlive time on the pooled runner threads to expire.  This could be addressed by adding a single method to StreamingUpdateSolrServer:
> {code:borderStyle=solid}
> public void shutdown() {
>     scheduler.shutdown();
> }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-2873) StreamingUpdateSolrServer does not provide public access to shutdown ExecutorService scheduler

Posted by "Lance Norskog (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145174#comment-13145174 ] 

Lance Norskog commented on SOLR-2873:
-------------------------------------

Ah! There is a matching problem lurking here: exceptions. There is no feedback from an executor to the main SUSS thread about a failure in indexing. Please add this to your patch.
                
> StreamingUpdateSolrServer does not provide public access to shutdown ExecutorService scheduler
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-2873
>                 URL: https://issues.apache.org/jira/browse/SOLR-2873
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 4.0
>         Environment: N/A
>            Reporter: Michael Gibney
>            Priority: Minor
>             Fix For: 4.0
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Applications do not exit until the StreamingUpdateSolrServer ExecutorService threads have died.  Currently, with no way to manually shut down the ExecutorService, an application that has completed execution will hang for 60s waiting for the keepAlive time on the pooled runner threads to expire.  This could be addressed by adding a single method to StreamingUpdateSolrServer:
> {code:borderStyle=solid}
> public void shutdown() {
>     scheduler.shutdown();
> }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org