You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Senthil Kumaran S <se...@collab.net> on 2008/12/11 10:58:21 UTC

[PATCH] Fix warning of signedness in fs_skels.c

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I am attaching a patch which fixes the following warning in
"subversion/libsvn_fs_base/util/fs_skels.c".

<snip>
../subversion/libsvn_fs_base/util/fs_skels.c: In function
'svn_fs_base__parse_representation_skel':
../subversion/libsvn_fs_base/util/fs_skels.c:558: warning: pointer targets in
passing argument 1 of 'svn_checksum__from_digest' differ in signedness
../subversion/libsvn_fs_base/util/fs_skels.c:566: warning: pointer targets in
passing argument 1 of 'svn_checksum__from_digest' differ in signedness
</snip>

[[[
Fix warning of signedness.

* subversion/libsvn_fs_base/util/fs_skels.c
  (svn_fs_base__parse_representation_skel): Typecast 'const char' to
   'const unsigned char' for checksum_skel->children->next->data.

Patch by: stylesen
]]]

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAklA8kwACgkQ9o1G+2zNQDiA8ACeMIsf1D957SdFh5mVZ7Inqhn1
FGkAoLlugL/0hFGXUVB0twuOOn+YIBSY
=9X6M
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=982774

Re: [PATCH] Fix warning of signedness in fs_skels.c

Posted by Senthil Kumaran S <se...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hyrum K. Wright wrote:
> Senthil Kumaran S wrote:
>> [[[
>> Fix warning of signedness.
>>
>> * subversion/libsvn_fs_base/util/fs_skels.c
>>   (svn_fs_base__parse_representation_skel): Typecast 'const char' to
>>    'const unsigned char' for checksum_skel->children->next->data.
>>
>> Patch by: stylesen
>> ]]]
> 
> Looks good to me.

Committed in r34687.

- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAklB9mgACgkQ9o1G+2zNQDhkCQCbBW/wm17mO8pD1riBVq5tYtwh
ioIAoKg9cl5DLP1dBrvfpSUdZ7KAO28O
=skSF
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=983211

Re: [PATCH] Fix warning of signedness in fs_skels.c

Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Senthil Kumaran S wrote:
> Hi,
> 
> I am attaching a patch which fixes the following warning in
> "subversion/libsvn_fs_base/util/fs_skels.c".
> 
> <snip>
> ../subversion/libsvn_fs_base/util/fs_skels.c: In function
> 'svn_fs_base__parse_representation_skel':
> ../subversion/libsvn_fs_base/util/fs_skels.c:558: warning: pointer targets in
> passing argument 1 of 'svn_checksum__from_digest' differ in signedness
> ../subversion/libsvn_fs_base/util/fs_skels.c:566: warning: pointer targets in
> passing argument 1 of 'svn_checksum__from_digest' differ in signedness
> </snip>
> 
> [[[
> Fix warning of signedness.
> 
> * subversion/libsvn_fs_base/util/fs_skels.c
>   (svn_fs_base__parse_representation_skel): Typecast 'const char' to
>    'const unsigned char' for checksum_skel->children->next->data.
> 
> Patch by: stylesen
> ]]]

Looks good to me.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=982865