You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/07/22 13:02:16 UTC

[GitHub] [cassandra] Claudenw opened a new pull request, #1741: Fix for CASSANDRA-14218

Claudenw opened a new pull request, #1741:
URL: https://github.com/apache/cassandra/pull/1741

   Replaced all occurances of `Throwables.propagate()`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] smiklosovic closed pull request #1741: Fix for CASSANDRA-14218: Deprecate Throwables.propagate usage

Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #1741: Fix for CASSANDRA-14218: Deprecate Throwables.propagate usage
URL: https://github.com/apache/cassandra/pull/1741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] Claudenw commented on pull request #1741: Fix for CASSANDRA-14218: Deprecate Throwables.propagate usage

Posted by GitBox <gi...@apache.org>.
Claudenw commented on PR #1741:
URL: https://github.com/apache/cassandra/pull/1741#issuecomment-1216315548

   Attached is a patch based on the fixes presented:  
   
   [CASSANDRA-14218.txt](https://github.com/apache/cassandra/files/9349084/CASSANDRA-14218.txt)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] dcapwell commented on a diff in pull request #1741: Fix for CASSANDRA-14218: Deprecate Throwables.propagate usage

Posted by GitBox <gi...@apache.org>.
dcapwell commented on code in PR #1741:
URL: https://github.com/apache/cassandra/pull/1741#discussion_r976742369


##########
src/java/org/apache/cassandra/streaming/management/ProgressInfoCompositeData.java:
##########
@@ -68,7 +66,7 @@
         }
         catch (OpenDataException e)
         {
-            throw Throwables.propagate(e);
+            throw new RuntimeException(e);           

Review Comment:
   extra space



##########
src/java/org/apache/cassandra/streaming/management/StreamStateCompositeData.java:
##########
@@ -67,7 +66,7 @@
         }
         catch (OpenDataException e)
         {
-            throw Throwables.propagate(e);
+            throw new RuntimeException(e);        

Review Comment:
   extra space



##########
src/java/org/apache/cassandra/tools/LoaderOptions.java:
##########
@@ -174,9 +173,9 @@ public LoaderOptions build()
             }
             catch (UnknownHostException e)
             {
-                Throwables.propagate(e);
+                throw new RuntimeException(e);
             }
-
+            

Review Comment:
   extra space



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org